From 94ba4017669c0fab675f3d756d95bc63fe543db5 Mon Sep 17 00:00:00 2001 From: Svet Ganov Date: Sun, 3 Apr 2016 22:04:22 -0700 Subject: [PATCH] Use proper package name and UID when checking write settings access bug:26941229 Change-Id: I338fe6dd7c1b97f273909672cdd7d4fa207185ce --- core/java/android/provider/Settings.java | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/core/java/android/provider/Settings.java b/core/java/android/provider/Settings.java index 69dd9e5abe69b..f4d63acdb4e88 100755 --- a/core/java/android/provider/Settings.java +++ b/core/java/android/provider/Settings.java @@ -1569,9 +1569,8 @@ public final class Settings { * @return true if the calling app can draw on top of other apps, false otherwise. */ public static boolean canDrawOverlays(Context context) { - int uid = Binder.getCallingUid(); - return Settings.isCallingPackageAllowedToDrawOverlays(context, uid, Settings - .getPackageNameForUid(context, uid), false); + return Settings.isCallingPackageAllowedToDrawOverlays(context, Process.myUid(), + context.getOpPackageName(), false); } /** @@ -3885,9 +3884,8 @@ public final class Settings { * @return true if the calling app can write to system settings, false otherwise */ public static boolean canWrite(Context context) { - int uid = Binder.getCallingUid(); - return isCallingPackageAllowedToWriteSettings(context, uid, getPackageNameForUid( - context, uid), false); + return isCallingPackageAllowedToWriteSettings(context, Process.myUid(), + context.getOpPackageName(), false); } }