From 9440df91057bb1c7a2cc03e9a61468dc725cfa4f Mon Sep 17 00:00:00 2001 From: Jackal Guo Date: Mon, 21 Jun 2021 13:08:56 +0800 Subject: [PATCH] Remove unused interface and implementation Get rid of the unused method to mitigate the potential information leakage. Bug: 185124942 Test: atest view-compiler-tests Test: atest android.view.cts.LayoutInflaterTest Test: atest -p core/java/android/content/pm Test: atest -p services/core/java/com/android/server/pm Test: manually using the PoC in the buganizer to ensure the symptom no longer exists. Change-Id: I5ee7381728a93535849fcf61a1373a5ed9036aa4 --- core/java/android/content/pm/IPackageManager.aidl | 5 ----- .../android/server/pm/PackageManagerService.java | 15 --------------- 2 files changed, 20 deletions(-) diff --git a/core/java/android/content/pm/IPackageManager.aidl b/core/java/android/content/pm/IPackageManager.aidl index c2ac80e7c98f9..d3ed006083244 100644 --- a/core/java/android/content/pm/IPackageManager.aidl +++ b/core/java/android/content/pm/IPackageManager.aidl @@ -585,11 +585,6 @@ interface IPackageManager { boolean performDexOptSecondary(String packageName, String targetCompilerFilter, boolean force); - /** - * Ask the package manager to compile layouts in the given package. - */ - boolean compileLayouts(String packageName); - /** * Ask the package manager to dump profiles associated with a package. */ diff --git a/services/core/java/com/android/server/pm/PackageManagerService.java b/services/core/java/com/android/server/pm/PackageManagerService.java index b02b704283f6d..144196b291dd2 100644 --- a/services/core/java/com/android/server/pm/PackageManagerService.java +++ b/services/core/java/com/android/server/pm/PackageManagerService.java @@ -12677,21 +12677,6 @@ public class PackageManagerService extends IPackageManager.Stub return performDexOpt(new DexoptOptions(packageName, compilerFilter, flags)); } - /** - * Ask the package manager to compile layouts in the given package. - */ - @Override - public boolean compileLayouts(String packageName) { - AndroidPackage pkg; - synchronized (mLock) { - pkg = mPackages.get(packageName); - if (pkg == null) { - return false; - } - } - return mViewCompiler.compileLayouts(pkg); - } - /*package*/ boolean performDexOpt(DexoptOptions options) { if (getInstantAppPackageName(Binder.getCallingUid()) != null) { return false;