Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge "Emulator: handle OOM and Protocol error cases"

Browse Source
This commit is contained in:
Roman Kiryanov
2022-12-13 21:32:42 +00:00
committed by Gerrit Code Review
parent 4215d4a2af e5b03a179a
commit 940ca0c415
1 changed files with 14 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
services/core/java/com/android/server/clipboard/EmulatorClipboardMonitor.java
View File

@@ -29,6 +29,7 @@ import android.util.Slog;
import java.io.EOFException; import java.io.EOFException;
import java.io.FileDescriptor; import java.io.FileDescriptor;
import java.io.InterruptedIOException; import java.io.InterruptedIOException;
import java.net.ProtocolException;
import java.net.SocketException; import java.net.SocketException;
import java.nio.ByteBuffer; import java.nio.ByteBuffer;
import java.nio.ByteOrder; import java.nio.ByteOrder;
@@ -39,12 +40,16 @@ import java.util.function.Consumer;
// write contents of the host system's clipboard. // write contents of the host system's clipboard.
class EmulatorClipboardMonitor implements Consumer<ClipData> { class EmulatorClipboardMonitor implements Consumer<ClipData> {
private static final String TAG = "EmulatorClipboardMonitor"; private static final String TAG = "EmulatorClipboardMonitor";
private static final String PIPE_NAME = "pipe:clipboard"; private static final String PIPE_NAME = "pipe:clipboard";
private static final int HOST_PORT = 5000; private static final int HOST_PORT = 5000;
private final Thread mHostMonitorThread;
private static final boolean LOG_CLIBOARD_ACCESS = private static final boolean LOG_CLIBOARD_ACCESS =
SystemProperties.getBoolean("ro.boot.qemu.log_clipboard_access", false); SystemProperties.getBoolean("ro.boot.qemu.log_clipboard_access", false);
private static final int MAX_CLIPBOARD_BYTES = 128 << 20;
private FileDescriptor mPipe = null; private FileDescriptor mPipe = null;
private final Thread mHostMonitorThread;
private static byte[] createOpenHandshake() { private static byte[] createOpenHandshake() {
// String.getBytes doesn't include the null terminator, // String.getBytes doesn't include the null terminator,
@@ -97,8 +102,8 @@ class EmulatorClipboardMonitor implements Consumer<ClipData> {
return fd; return fd;
} }
private static byte[] receiveMessage(final FileDescriptor fd) throws ErrnoException, private byte[] receiveMessage(final FileDescriptor fd) throws ErrnoException,
InterruptedIOException, EOFException { InterruptedIOException, EOFException, ProtocolException {
final byte[] lengthBits = new byte[4]; final byte[] lengthBits = new byte[4];
readFully(fd, lengthBits, 0, lengthBits.length); readFully(fd, lengthBits, 0, lengthBits.length);
@@ -106,6 +111,10 @@ class EmulatorClipboardMonitor implements Consumer<ClipData> {
bb.order(ByteOrder.LITTLE_ENDIAN); bb.order(ByteOrder.LITTLE_ENDIAN);
final int msgLen = bb.getInt(); final int msgLen = bb.getInt();
if (msgLen <= 0 || msgLen > MAX_CLIPBOARD_BYTES) {
throw new ProtocolException("Clipboard message length: " + msgLen + " out of bounds.");
}
final byte[] msg = new byte[msgLen]; final byte[] msg = new byte[msgLen];
readFully(fd, msg, 0, msg.length); readFully(fd, msg, 0, msg.length);
@@ -150,7 +159,8 @@ class EmulatorClipboardMonitor implements Consumer<ClipData> {
} }
setAndroidClipboard.accept(clip); setAndroidClipboard.accept(clip);
} catch (ErrnoException | EOFException | InterruptedIOException } catch (ErrnoException | EOFException | InterruptedIOException
| InterruptedException e) { | InterruptedException | ProtocolException | OutOfMemoryError e) {
Slog.w(TAG, "Failure to read from host clipboard", e);
setPipeFD(null); setPipeFD(null);
try { try {