From 7ca96381addaacdf3aab6607924a66d13461fa64 Mon Sep 17 00:00:00 2001 From: Joe Bolinger Date: Tue, 27 Apr 2021 18:15:34 -0700 Subject: [PATCH] Fix oneway complaints for face auth. Bug: 186047141 Test: adb logcat -s Binder:E -e "IFace.*getSensorProps" (is blank) Change-Id: I95006e0c2c0048bbaac2a114ab85ae4702a43662 --- .../android/server/biometrics/sensors/face/FaceService.java | 2 +- .../server/biometrics/sensors/face/aidl/FaceProvider.java | 5 ++++- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/services/core/java/com/android/server/biometrics/sensors/face/FaceService.java b/services/core/java/com/android/server/biometrics/sensors/face/FaceService.java index 94d47aa029a26..779558e8893e1 100644 --- a/services/core/java/com/android/server/biometrics/sensors/face/FaceService.java +++ b/services/core/java/com/android/server/biometrics/sensors/face/FaceService.java @@ -632,7 +632,7 @@ public class FaceService extends SystemService { for (String instance : instances) { final String fqName = IFace.DESCRIPTOR + "/" + instance; final IFace face = IFace.Stub.asInterface( - ServiceManager.waitForDeclaredService(fqName)); + Binder.allowBlocking(ServiceManager.waitForDeclaredService(fqName))); if (face == null) { Slog.e(TAG, "Unable to get declared service: " + fqName); continue; diff --git a/services/core/java/com/android/server/biometrics/sensors/face/aidl/FaceProvider.java b/services/core/java/com/android/server/biometrics/sensors/face/aidl/FaceProvider.java index 23be50e5925ae..84d239ef2b504 100644 --- a/services/core/java/com/android/server/biometrics/sensors/face/aidl/FaceProvider.java +++ b/services/core/java/com/android/server/biometrics/sensors/face/aidl/FaceProvider.java @@ -33,6 +33,7 @@ import android.hardware.biometrics.face.SensorProps; import android.hardware.face.Face; import android.hardware.face.FaceSensorPropertiesInternal; import android.hardware.face.IFaceServiceReceiver; +import android.os.Binder; import android.os.Handler; import android.os.IBinder; import android.os.Looper; @@ -173,7 +174,9 @@ public class FaceProvider implements IBinder.DeathRecipient, ServiceProvider { Slog.d(getTag(), "Daemon was null, reconnecting"); mDaemon = IFace.Stub.asInterface( - ServiceManager.waitForDeclaredService(IFace.DESCRIPTOR + "/" + mHalInstanceName)); + Binder.allowBlocking( + ServiceManager.waitForDeclaredService( + IFace.DESCRIPTOR + "/" + mHalInstanceName))); if (mDaemon == null) { Slog.e(getTag(), "Unable to get daemon"); return null;