diff --git a/libs/hwui/Android.mk b/libs/hwui/Android.mk index 62594667086a2..8857c41dc33d5 100644 --- a/libs/hwui/Android.mk +++ b/libs/hwui/Android.mk @@ -247,6 +247,7 @@ LOCAL_SRC_FILES += \ tests/unit/DamageAccumulatorTests.cpp \ tests/unit/DeviceInfoTests.cpp \ tests/unit/FatVectorTests.cpp \ + tests/unit/FontRendererTests.cpp \ tests/unit/GlopBuilderTests.cpp \ tests/unit/GpuMemoryTrackerTests.cpp \ tests/unit/GradientCacheTests.cpp \ diff --git a/libs/hwui/FontRenderer.cpp b/libs/hwui/FontRenderer.cpp index 1b618c6a71c6a..276c18d0d3f9e 100644 --- a/libs/hwui/FontRenderer.cpp +++ b/libs/hwui/FontRenderer.cpp @@ -689,7 +689,7 @@ bool FontRenderer::renderTextOnPath(const SkPaint* paint, const Rect* clip, cons void FontRenderer::blurImage(uint8_t** image, int32_t width, int32_t height, float radius) { uint32_t intRadius = Blur::convertRadiusToInt(radius); #ifdef ANDROID_ENABLE_RENDERSCRIPT - if (width * height * intRadius >= RS_MIN_INPUT_CUTOFF) { + if (width * height * intRadius >= RS_MIN_INPUT_CUTOFF && radius <= 25.0f) { uint8_t* outImage = (uint8_t*) memalign(RS_CPU_ALLOCATION_ALIGNMENT, width * height); if (mRs == nullptr) { diff --git a/libs/hwui/tests/unit/FontRendererTests.cpp b/libs/hwui/tests/unit/FontRendererTests.cpp new file mode 100644 index 0000000000000..99080ac938e74 --- /dev/null +++ b/libs/hwui/tests/unit/FontRendererTests.cpp @@ -0,0 +1,55 @@ +/* + * Copyright (C) 2016 The Android Open Source Project + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +#include + +#include "GammaFontRenderer.h" +#include "tests/common/TestUtils.h" + +using namespace android::uirenderer; + +static bool isZero(uint8_t* data, int size) { + for (int i = 0; i < size; i++) { + if (data[i]) return false; + } + return true; +} + +RENDERTHREAD_TEST(FontRenderer, renderDropShadow) { + SkPaint paint; + paint.setTextSize(10); + paint.setTextEncoding(SkPaint::kGlyphID_TextEncoding); + GammaFontRenderer gammaFontRenderer; + FontRenderer& fontRenderer = gammaFontRenderer.getFontRenderer(); + fontRenderer.setFont(&paint, SkMatrix::I()); + + std::vector glyphs; + std::vector positions; + float totalAdvance; + Rect bounds; + TestUtils::layoutTextUnscaled(paint, "This is a test", + &glyphs, &positions, &totalAdvance, &bounds); + + for (int radius : {28, 20, 2}) { + auto result = fontRenderer.renderDropShadow(&paint, glyphs.data(), glyphs.size(), + radius, positions.data()); + ASSERT_NE(nullptr, result.image); + EXPECT_FALSE(isZero(result.image, result.width * result.height)); + EXPECT_LE(bounds.getWidth() + radius * 2, (int) result.width); + EXPECT_LE(bounds.getHeight() + radius * 2, (int) result.height); + delete result.image; + } +}