From 9231eaf451d25a60ccb5ca1483328c2849852246 Mon Sep 17 00:00:00 2001 From: Ben Murdoch Date: Thu, 4 Apr 2019 14:29:49 +0100 Subject: [PATCH] Fixup App Compaction CL nits. A couple of nits to cleanup from change I71fffc52a232cd5608742d9f36965a4de6494b56 - remove unused method - remove unnecessary null check. BUG: 128427978 Test: atest FrameworksMockingServicesTests:AppCompactorTest Change-Id: I363c57fc78529207585f5d1e004770d967ce87b9 --- .../com/android/server/am/AppCompactor.java | 24 +++++++------------ 1 file changed, 9 insertions(+), 15 deletions(-) diff --git a/services/core/java/com/android/server/am/AppCompactor.java b/services/core/java/com/android/server/am/AppCompactor.java index 043dc8d000810..13b55dbcad48e 100644 --- a/services/core/java/com/android/server/am/AppCompactor.java +++ b/services/core/java/com/android/server/am/AppCompactor.java @@ -278,17 +278,15 @@ public final class AppCompactor { + " full, " + mPersistentCompactionCount + " persistent, " + mBfgsCompactionCount + " BFGS compactions."); - if (mLastCompactionStats != null) { - pw.println(" Tracking last compaction stats for " + mLastCompactionStats.size() - + " processes."); - if (DEBUG_COMPACTION) { - for (Map.Entry entry - : mLastCompactionStats.entrySet()) { - int pid = entry.getKey(); - LastCompactionStats stats = entry.getValue(); - pw.println(" " + pid + ": " - + Arrays.toString(stats.getRssAfterCompaction())); - } + pw.println(" Tracking last compaction stats for " + mLastCompactionStats.size() + + " processes."); + if (DEBUG_COMPACTION) { + for (Map.Entry entry + : mLastCompactionStats.entrySet()) { + int pid = entry.getKey(); + LastCompactionStats stats = entry.getValue(); + pw.println(" " + pid + ": " + + Arrays.toString(stats.getRssAfterCompaction())); } } } @@ -506,10 +504,6 @@ public final class AppCompactor { } } - @VisibleForTesting static String procStateListToString(Integer... processStates) { - return Arrays.toString(processStates); - } - private static final class LastCompactionStats { private final long[] mRssAfterCompaction;