From 58311dcc70bc0ca3ce2253d3d96a0422e48d11be Mon Sep 17 00:00:00 2001 From: Steven Moreland Date: Wed, 30 Dec 2020 19:46:57 +0000 Subject: [PATCH] TransactionTooLargeException: doc clarification - buffer is in bytes, not bits (1MB vs 1Mb) - this exception is actually a heuristic currently, pending b/28321379 Fixes: 149869862 Test: N/A Change-Id: Id409a1ce7348666ec9ad6437acf67382be0a0a1f --- core/java/android/os/TransactionTooLargeException.java | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/core/java/android/os/TransactionTooLargeException.java b/core/java/android/os/TransactionTooLargeException.java index 10abf26420f1d..4d5b2a10f3fee 100644 --- a/core/java/android/os/TransactionTooLargeException.java +++ b/core/java/android/os/TransactionTooLargeException.java @@ -23,9 +23,11 @@ import android.os.RemoteException; * During a remote procedure call, the arguments and the return value of the call * are transferred as {@link Parcel} objects stored in the Binder transaction buffer. * If the arguments or the return value are too large to fit in the transaction buffer, - * then the call will fail and {@link TransactionTooLargeException} will be thrown. + * then the call will fail. {@link TransactionTooLargeException} is thrown as a + * heuristic when a transaction is large, and it fails, since these are the transactions + * which are most likely to overfill the transaction buffer. *

- * The Binder transaction buffer has a limited fixed size, currently 1Mb, which + * The Binder transaction buffer has a limited fixed size, currently 1MB, which * is shared by all transactions in progress for the process. Consequently this * exception can be thrown when there are many transactions in progress even when * most of the individual transactions are of moderate size.