From 4575d900207fc354a4f2cf65c74588b23fc93ff7 Mon Sep 17 00:00:00 2001 From: Alex Buynytskyy Date: Thu, 17 Nov 2022 01:23:27 +0000 Subject: [PATCH] Don't crash the system if there is broken precondition. Bug: 257403361 Fixes: 257403361 Test: presubmit Change-Id: Iabd2833fd590c8c5d49aeb6f8c0b538c0e2508c6 --- .../java/com/android/server/pm/PackageInstallerSession.java | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/services/core/java/com/android/server/pm/PackageInstallerSession.java b/services/core/java/com/android/server/pm/PackageInstallerSession.java index 5d13a45e03e31..3cc19071a213d 100644 --- a/services/core/java/com/android/server/pm/PackageInstallerSession.java +++ b/services/core/java/com/android/server/pm/PackageInstallerSession.java @@ -3711,7 +3711,9 @@ public class PackageInstallerSession extends IPackageInstallerSession.Stub { private boolean dispatchPendingAbandonCallback() { final Runnable callback; synchronized (mLock) { - Preconditions.checkState(mStageDirInUse); + if (!mStageDirInUse) { + return false; + } mStageDirInUse = false; callback = mPendingAbandonCallback; mPendingAbandonCallback = null;