From 91eb0354043842d96bf3ef201ce68046db70df74 Mon Sep 17 00:00:00 2001 From: Andreas Huber Date: Mon, 7 Dec 2009 09:43:00 -0800 Subject: [PATCH] Change OMXCodec::Create to return an sp instead of an sp, this is more general and does not sacrifice any functionality as the remaining OMXCodec APIs are not meant to be public anyway. --- cmds/stagefright/audioloop.cpp | 4 ++-- cmds/stagefright/record.cpp | 4 ++-- include/media/stagefright/OMXCodec.h | 2 +- media/libstagefright/OMXCodec.cpp | 2 +- 4 files changed, 6 insertions(+), 6 deletions(-) diff --git a/cmds/stagefright/audioloop.cpp b/cmds/stagefright/audioloop.cpp index 70ab5594a89f3..3788e73b17dea 100644 --- a/cmds/stagefright/audioloop.cpp +++ b/cmds/stagefright/audioloop.cpp @@ -38,12 +38,12 @@ int main() { meta->setInt32(kKeyMaxInputSize, maxInputSize); } - sp encoder = OMXCodec::Create( + sp encoder = OMXCodec::Create( client.interface(), meta, true /* createEncoder */, source); - sp decoder = OMXCodec::Create( + sp decoder = OMXCodec::Create( client.interface(), meta, false /* createEncoder */, encoder); diff --git a/cmds/stagefright/record.cpp b/cmds/stagefright/record.cpp index a31a5c0538865..2ec0b702d41fa 100644 --- a/cmds/stagefright/record.cpp +++ b/cmds/stagefright/record.cpp @@ -154,7 +154,7 @@ int main(int argc, char **argv) { sp meta = source->getFormat(); - sp decoder = OMXCodec::Create( + sp decoder = OMXCodec::Create( client.interface(), meta, false /* createEncoder */, source); int width, height; @@ -173,7 +173,7 @@ int main(int argc, char **argv) { enc_meta->setInt32(kKeyWidth, width); enc_meta->setInt32(kKeyHeight, height); - sp encoder = + sp encoder = OMXCodec::Create( client.interface(), enc_meta, true /* createEncoder */, decoder); diff --git a/include/media/stagefright/OMXCodec.h b/include/media/stagefright/OMXCodec.h index 41992520dfa08..351763cbefbcb 100644 --- a/include/media/stagefright/OMXCodec.h +++ b/include/media/stagefright/OMXCodec.h @@ -33,7 +33,7 @@ struct OMXCodec : public MediaSource, enum CreationFlags { kPreferSoftwareCodecs = 1, }; - static sp Create( + static sp Create( const sp &omx, const sp &meta, bool createEncoder, const sp &source, diff --git a/media/libstagefright/OMXCodec.cpp b/media/libstagefright/OMXCodec.cpp index 670f748bfa795..7c772148089ef 100644 --- a/media/libstagefright/OMXCodec.cpp +++ b/media/libstagefright/OMXCodec.cpp @@ -274,7 +274,7 @@ void OMXCodec::findMatchingCodecs( } // static -sp OMXCodec::Create( +sp OMXCodec::Create( const sp &omx, const sp &meta, bool createEncoder, const sp &source,