From 546220dde097e3db8d9b33435174ee89078ace92 Mon Sep 17 00:00:00 2001 From: Caitlin Shkuratov Date: Fri, 28 Jul 2023 19:44:34 +0000 Subject: [PATCH] [Mobile] Log the visibilities received by icon views. Bug: 291031862 Test: toggle SIM on/off and toggle airplane mode on/off -> verify `adb shell dumpsys activity service com.android.systemui/.SystemUIService VerboseMobileViewLog` logs visibility changes Change-Id: Ib1c78ab49b8a20748dbbf794350eaaf5943aad52 --- .../pipeline/mobile/ui/VerboseMobileViewLogger.kt | 13 +++++++++++++ .../pipeline/mobile/ui/binder/MobileIconBinder.kt | 11 ++++++++++- 2 files changed, 23 insertions(+), 1 deletion(-) diff --git a/packages/SystemUI/src/com/android/systemui/statusbar/pipeline/mobile/ui/VerboseMobileViewLogger.kt b/packages/SystemUI/src/com/android/systemui/statusbar/pipeline/mobile/ui/VerboseMobileViewLogger.kt index f4c572308e59d..cffc833eaf882 100644 --- a/packages/SystemUI/src/com/android/systemui/statusbar/pipeline/mobile/ui/VerboseMobileViewLogger.kt +++ b/packages/SystemUI/src/com/android/systemui/statusbar/pipeline/mobile/ui/VerboseMobileViewLogger.kt @@ -38,6 +38,19 @@ class VerboseMobileViewLogger constructor( @VerboseMobileViewLog private val buffer: LogBuffer, ) { + fun logBinderReceivedVisibility(parentView: View, subId: Int, visibility: Boolean) { + buffer.log( + TAG, + LogLevel.VERBOSE, + { + str1 = parentView.getIdForLogging() + int1 = subId + bool1 = visibility + }, + { "Binder[subId=$int1, viewId=$str1] received visibility: $bool1" }, + ) + } + fun logBinderReceivedSignalIcon(parentView: View, subId: Int, icon: SignalIconModel) { buffer.log( TAG, diff --git a/packages/SystemUI/src/com/android/systemui/statusbar/pipeline/mobile/ui/binder/MobileIconBinder.kt b/packages/SystemUI/src/com/android/systemui/statusbar/pipeline/mobile/ui/binder/MobileIconBinder.kt index c22110959fc1b..55bc8d58be23e 100644 --- a/packages/SystemUI/src/com/android/systemui/statusbar/pipeline/mobile/ui/binder/MobileIconBinder.kt +++ b/packages/SystemUI/src/com/android/systemui/statusbar/pipeline/mobile/ui/binder/MobileIconBinder.kt @@ -99,7 +99,16 @@ object MobileIconBinder { } } - launch { viewModel.isVisible.collect { isVisible -> view.isVisible = isVisible } } + launch { + viewModel.isVisible.collect { isVisible -> + viewModel.verboseLogger?.logBinderReceivedVisibility( + view, + viewModel.subscriptionId, + isVisible + ) + view.isVisible = isVisible + } + } // Set the icon for the triangle launch {