From 22bd242478fa9c9531cf0b750023db5a513eaa8c Mon Sep 17 00:00:00 2001 From: Andreas Huber Date: Wed, 11 Aug 2010 12:34:32 -0700 Subject: [PATCH] This code in CameraSource really should hold the lock. Change-Id: I349520a14776bb83b7edb23fc62052b487246d9a --- media/libstagefright/CameraSource.cpp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/media/libstagefright/CameraSource.cpp b/media/libstagefright/CameraSource.cpp index 9c48daf9348a3..3e31d6155aa0b 100644 --- a/media/libstagefright/CameraSource.cpp +++ b/media/libstagefright/CameraSource.cpp @@ -244,6 +244,7 @@ void CameraSource::releaseOneRecordingFrame(const sp& frame) { void CameraSource::signalBufferReturned(MediaBuffer *buffer) { LOGV("signalBufferReturned: %p", buffer->data()); + Mutex::Autolock autoLock(mLock); for (List >::iterator it = mFramesBeingEncoded.begin(); it != mFramesBeingEncoded.end(); ++it) { if ((*it)->pointer() == buffer->data()) { @@ -312,6 +313,7 @@ status_t CameraSource::read( (*buffer)->setObserver(this); (*buffer)->add_ref(); (*buffer)->meta_data()->setInt64(kKeyTime, frameTime); + return OK; } }