Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge "Process only app initiated removals in onEntryRemoved callback" into tm-dev

Browse Source
This commit is contained in:
Sergey Serokurov
2022-04-05 17:11:03 +00:00
committed by Android (Google) Code Review
parent 22f211ca1e e51ee7ee00
commit 9095108312
2 changed files with 5 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
packages/SystemUI/src/com/android/systemui/wmshell/BubblesManager.java
View File

@@ -576,7 +576,9 @@ public class BubblesManager implements Dumpable {
@Override @Override
public void onEntryRemoved(NotificationEntry entry, public void onEntryRemoved(NotificationEntry entry,
@NotifCollection.CancellationReason int reason) { @NotifCollection.CancellationReason int reason) {
BubblesManager.this.onEntryRemoved(entry); if (reason == REASON_APP_CANCEL || reason == REASON_APP_CANCEL_ALL) {
BubblesManager.this.onEntryRemoved(entry);
}
} }
@Override @Override

4
packages/SystemUI/tests/src/com/android/systemui/wmshell/NewNotifPipelineBubblesTest.java
View File

@@ -807,7 +807,7 @@ public class NewNotifPipelineBubblesTest extends SysuiTestCase {
assertTrue(mBubbleController.hasBubbles()); assertTrue(mBubbleController.hasBubbles());
// Removes the notification // Removes the notification
mEntryListener.onEntryRemoved(mRow, 0); mEntryListener.onEntryRemoved(mRow, REASON_APP_CANCEL);
assertFalse(mBubbleController.hasBubbles()); assertFalse(mBubbleController.hasBubbles());
} }
@@ -938,7 +938,7 @@ public class NewNotifPipelineBubblesTest extends SysuiTestCase {
mBubblesManager.handleDismissalInterception(groupSummary.getEntry()); mBubblesManager.handleDismissalInterception(groupSummary.getEntry());
// WHEN the summary is cancelled by the app // WHEN the summary is cancelled by the app
mEntryListener.onEntryRemoved(groupSummary.getEntry(), 0); mEntryListener.onEntryRemoved(groupSummary.getEntry(), REASON_APP_CANCEL);
// THEN the summary and its children are removed from bubble data // THEN the summary and its children are removed from bubble data
assertFalse(mBubbleData.hasBubbleInStackWithKey(groupedBubble.getEntry().getKey())); assertFalse(mBubbleData.hasBubbleInStackWithKey(groupedBubble.getEntry().getKey()));