From 23cc716cc52984a926de7643cfbae0a629913436 Mon Sep 17 00:00:00 2001 From: James Dong Date: Thu, 9 Feb 2012 17:32:57 -0800 Subject: [PATCH] Change the signature of method addTextSource() in AwesomePlayer o avoid a unnecessary copy constructor call Change-Id: Ib598bbe42d42a835549e2d29502c6f196f859874 --- media/libstagefright/AwesomePlayer.cpp | 2 +- media/libstagefright/include/AwesomePlayer.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/media/libstagefright/AwesomePlayer.cpp b/media/libstagefright/AwesomePlayer.cpp index aacfbddccd5ba..85b7979e3b02e 100644 --- a/media/libstagefright/AwesomePlayer.cpp +++ b/media/libstagefright/AwesomePlayer.cpp @@ -1360,7 +1360,7 @@ void AwesomePlayer::setAudioSource(sp source) { mAudioTrack = source; } -void AwesomePlayer::addTextSource(sp source) { +void AwesomePlayer::addTextSource(const sp& source) { Mutex::Autolock autoLock(mTimedTextLock); CHECK(source != NULL); diff --git a/media/libstagefright/include/AwesomePlayer.h b/media/libstagefright/include/AwesomePlayer.h index a7a3d47816338..4c7bfa684a138 100644 --- a/media/libstagefright/include/AwesomePlayer.h +++ b/media/libstagefright/include/AwesomePlayer.h @@ -258,7 +258,7 @@ private: void setVideoSource(sp source); status_t initVideoDecoder(uint32_t flags = 0); - void addTextSource(sp source); + void addTextSource(const sp& source); void onStreamDone();