From 7a0c18c8846344ce8b591da738ba9590ad32df2c Mon Sep 17 00:00:00 2001 From: lesl Date: Fri, 21 Feb 2020 16:28:00 +0800 Subject: [PATCH] wifi: correct API name The API:isFeatureSupported accept one or combination of required features, update the jave doc & rename to areFeaturesSupporte Bug: 149871866 Test: make docs frameworks/base/wifi/ Test: atest frameworks/base/wifi/tests/ Merged-In: I3bcbcfd04dced36b63436b5a96835fb0d8f35f3b Change-Id: I3bcbcfd04dced36b63436b5a96835fb0d8f35f3b (cherry picked from commit dd8f942e815381c2636b5981d91b3c59c7f27745) --- api/system-current.txt | 2 +- wifi/java/android/net/wifi/SoftApCapability.java | 10 +++++----- wifi/java/android/net/wifi/SoftApConfiguration.java | 7 ++++--- 3 files changed, 10 insertions(+), 9 deletions(-) diff --git a/api/system-current.txt b/api/system-current.txt index 85ad66f3dec70..f84b4158da086 100755 --- a/api/system-current.txt +++ b/api/system-current.txt @@ -7199,9 +7199,9 @@ package android.net.wifi { } public final class SoftApCapability implements android.os.Parcelable { + method public boolean areFeaturesSupported(long); method public int describeContents(); method public int getMaxSupportedClients(); - method public boolean isFeatureSupported(long); method public void writeToParcel(@NonNull android.os.Parcel, int); field @NonNull public static final android.os.Parcelable.Creator CREATOR; field public static final long SOFTAP_FEATURE_ACS_OFFLOAD = 1L; // 0x1L diff --git a/wifi/java/android/net/wifi/SoftApCapability.java b/wifi/java/android/net/wifi/SoftApCapability.java index a831984f3968a..18b26db1b020c 100644 --- a/wifi/java/android/net/wifi/SoftApCapability.java +++ b/wifi/java/android/net/wifi/SoftApCapability.java @@ -100,12 +100,12 @@ public final class SoftApCapability implements Parcelable { } /** - * Returns true when feature supported, otherwise false. + * Returns true when all of the queried features are supported, otherwise false. * - * @param feature one of feature from {@link HotspotFeatures} + * @param features One or combination of the features from {@link @HotspotFeatures} */ - public boolean isFeatureSupported(@HotspotFeatures long feature) { - return (mSupportedFeatures & feature) == feature; + public boolean areFeaturesSupported(@HotspotFeatures long features) { + return (mSupportedFeatures & features) == features; } /** @@ -122,7 +122,7 @@ public final class SoftApCapability implements Parcelable { * Constructor with combination of the feature. * Zero to no supported feature. * - * @param features One or combination of the feature from {@link @HotspotFeatures}. + * @param features One or combination of the features from {@link @HotspotFeatures}. * @hide */ public SoftApCapability(@HotspotFeatures long features) { diff --git a/wifi/java/android/net/wifi/SoftApConfiguration.java b/wifi/java/android/net/wifi/SoftApConfiguration.java index ae5bf7d5ae847..2b4762320f529 100644 --- a/wifi/java/android/net/wifi/SoftApConfiguration.java +++ b/wifi/java/android/net/wifi/SoftApConfiguration.java @@ -762,7 +762,8 @@ public final class SoftApConfiguration implements Parcelable { * {@link #setBand(@BandType int)}. * * The channel auto selection will offload to driver when - * {@link SoftApCapability#isFeatureSupported(SoftApCapability.SOFTAP_FEATURE_ACS_OFFLOAD)} + * {@link SoftApCapability#areFeaturesSupported( + * SoftApCapability.SOFTAP_FEATURE_ACS_OFFLOAD)} * return true. Driver will auto select best channel which based on environment * interference to get best performance. Check {@link SoftApCapability} to get more detail. * @@ -807,7 +808,7 @@ public final class SoftApConfiguration implements Parcelable { * *

* Use {@link WifiManager.SoftApCallback#onCapabilityChanged(SoftApCapability)} and - * {@link SoftApCapability#isFeatureSupported(int)} + * {@link SoftApCapability#areFeaturesSupported(int)} * with {@link SoftApCapability.SOFTAP_FEATURE_CLIENT_FORCE_DISCONNECT} to determine whether * or not this feature is supported. * @@ -882,7 +883,7 @@ public final class SoftApConfiguration implements Parcelable { *

* This method requires hardware support. Hardware support can be determined using * {@link WifiManager.SoftApCallback#onCapabilityChanged(SoftApCapability)} and - * {@link SoftApCapability#isFeatureSupported(int)} + * {@link SoftApCapability#areFeaturesSupported(int)} * with {@link SoftApCapability.SOFTAP_FEATURE_CLIENT_FORCE_DISCONNECT} * *