Merge "Clean up code of starting bug report" into rvc-dev am: 4328b613a8

Change-Id: I70f1f3d4bb8107054a446cc33c5b239c92ff5f35

packages/Shell/src/com/android/shell/BugreportProgressService.java

@@ -615,13 +615,16 @@ public class BugreportProgressService extends Service {
                     + " bugreport parcel file descriptor is null.");
             return;
         }
-        ParcelFileDescriptor screenshotFd = info.getDefaultScreenshotFd();
+        ParcelFileDescriptor screenshotFd = null;
-        if (screenshotFd == null) {
+        if (isDefaultScreenshotRequired(bugreportType)) {
-            Log.e(TAG, "Failed to start bugreport generation as"
+            screenshotFd = info.getDefaultScreenshotFd();
-                    + " screenshot parcel file descriptor is null. Deleting bugreport file");
+            if (screenshotFd == null) {
-            FileUtils.closeQuietly(bugreportFd);
+                Log.e(TAG, "Failed to start bugreport generation as"
-            info.bugreportFile.delete();
+                        + " screenshot parcel file descriptor is null. Deleting bugreport file");
-            return;
+                FileUtils.closeQuietly(bugreportFd);
+                info.bugreportFile.delete();
+                return;
+            }
         }
 
         mBugreportManager = (BugreportManager) mContext.getSystemService(
@@ -641,10 +644,20 @@ public class BugreportProgressService extends Service {
             // The binder call didn't go through successfully, so need to close the fds.
             // If the calls went through API takes ownership.
             FileUtils.closeQuietly(bugreportFd);
-            FileUtils.closeQuietly(screenshotFd);
+            if (screenshotFd != null) {
+                FileUtils.closeQuietly(screenshotFd);
+            }
         }
     }
 
+    private static boolean isDefaultScreenshotRequired(
+            @BugreportParams.BugreportMode int bugreportType) {
+        // Modify dumpstate#SetOptionsFromMode as well for default system screenshots.
+        // We override dumpstate for interactive bugreports.
+        return bugreportType == BugreportParams.BUGREPORT_MODE_FULL
+                || bugreportType == BugreportParams.BUGREPORT_MODE_WEAR;
+    }
+
     private static ParcelFileDescriptor getFd(File file) {
         try {
             return ParcelFileDescriptor.open(file,