From 2f77697ea8498cd61322f3541c05ad90e3b1e7c9 Mon Sep 17 00:00:00 2001 From: Yohei Yukawa Date: Wed, 4 Nov 2020 18:01:37 -0800 Subject: [PATCH] Increase StartInputHistory entry size We have been receiving an increasing number of reports that say the device went to a weird state where the keyboard stopped showing up. One of the challenges when diagnosing this types of issues is that the reporter often keeps using the device after triggering the bugreport and the most important logs in StartInputHistory were already gone when InputMethodManagerService#dump() got called. Ideally IMMS should be able to suppress logging while a bugreport is being taken, but let's simply increase the entry size for now. Bug: 171637033 Bug: 171792138 Bug: 171597353 Test: adb shell dumpsys input_method Change-Id: I10450c7b78908a8c16949fa94f76fc76156a3bc2 --- .../android/server/inputmethod/InputMethodManagerService.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/services/core/java/com/android/server/inputmethod/InputMethodManagerService.java b/services/core/java/com/android/server/inputmethod/InputMethodManagerService.java index 683a4b67cc635..6dd91e533a87a 100644 --- a/services/core/java/com/android/server/inputmethod/InputMethodManagerService.java +++ b/services/core/java/com/android/server/inputmethod/InputMethodManagerService.java @@ -938,7 +938,7 @@ public class InputMethodManagerService extends IInputMethodManager.Stub *

TODO: Consider to follow what other system services have been doing to manage * constants (e.g. {@link android.provider.Settings.Global#ACTIVITY_MANAGER_CONSTANTS}).

*/ - private final static int ENTRY_SIZE_FOR_HIGH_RAM_DEVICE = 16; + private final static int ENTRY_SIZE_FOR_HIGH_RAM_DEVICE = 32; /** * Entry size for non low-RAM devices.