From 8dc208476f1fbbf6cd0b8cc3d48487a62cb72883 Mon Sep 17 00:00:00 2001 From: Marco Nelissen Date: Wed, 28 Sep 2011 09:21:11 -0700 Subject: [PATCH] Log a warning when a MediaPlayer is finalized without having being released. b/5382634 Change-Id: I756d09d16a92ab8ce736c16a24e319a87be6c8de --- media/jni/android_media_MediaPlayer.cpp | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/media/jni/android_media_MediaPlayer.cpp b/media/jni/android_media_MediaPlayer.cpp index c270f21a7b25e..f3174fef26664 100644 --- a/media/jni/android_media_MediaPlayer.cpp +++ b/media/jni/android_media_MediaPlayer.cpp @@ -651,6 +651,10 @@ static void android_media_MediaPlayer_native_finalize(JNIEnv *env, jobject thiz) { LOGV("native_finalize"); + sp mp = getMediaPlayer(env, thiz); + if (mp != NULL) { + LOGW("MediaPlayer finalized without being released"); + } android_media_MediaPlayer_release(env, thiz); }