From 9e1923d02fbc161abe107c814224c594cb4beb56 Mon Sep 17 00:00:00 2001 From: Adam Lesinski Date: Thu, 11 Feb 2016 14:17:25 -0800 Subject: [PATCH] AAPT: Remove warnings for public resources without comments There are so many public resources that do not warrant comments that having a warning that no one cares about is just producing log spam. Bug:21495023 Change-Id: I84e3b39c7139ee67fb5cb711d5ab466d8f4ef2e0 --- tools/aapt/Resource.cpp | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/tools/aapt/Resource.cpp b/tools/aapt/Resource.cpp index 4d9ba6c95d9e2..18a194326de77 100644 --- a/tools/aapt/Resource.cpp +++ b/tools/aapt/Resource.cpp @@ -1883,8 +1883,6 @@ status_t buildResources(Bundle* bundle, const sp& assets, spappendComment(String8(e), String16(cmt), srcPos); - } else { - //printf("No comment for %s\n", String8(e).string()); } syms->makeSymbolPublic(String8(e), srcPos); } else if (strcmp16(block.getElementName(&len), uses_permission16.string()) == 0) { @@ -2535,10 +2533,6 @@ static status_t writeSymbolClass( fprintf(fp, "%s/** %s\n", getIndentSpace(indent), cmt.string()); - } else if (sym.isPublic && !includePrivate) { - sym.sourcePos.warning("No comment for public symbol %s:%s/%s", - assets->getPackage().string(), className.string(), - String8(sym.name).string()); } String16 typeComment(sym.typeComment); if (typeComment.size() > 0) { @@ -2581,10 +2575,6 @@ static status_t writeSymbolClass( "%s */\n", getIndentSpace(indent), cmt.string(), getIndentSpace(indent)); - } else if (sym.isPublic && !includePrivate) { - sym.sourcePos.warning("No comment for public symbol %s:%s/%s", - assets->getPackage().string(), className.string(), - String8(sym.name).string()); } ann.printAnnotations(fp, getIndentSpace(indent)); fprintf(fp, "%spublic static final String %s=\"%s\";\n",