Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge "[Bugfix][RemoteAnimation] Fix IndexOutOfBoundsException in onAnimationFinished of RemoteAnimationController" am: 4b7206b8d8 am: b7e86b3e01

Browse Source 
Original change: https://android-review.googlesource.com/c/platform/frameworks/base/+/2132452

Change-Id: I6580aa3a6badfc17cb0dc57b1a675f9a6c9e7c33
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
This commit is contained in:
Chris Li
2022-07-11 07:34:45 +00:00
committed by Automerger Merge Worker
parent 37accfd817 b7e86b3e01
commit 8d5e476385
1 changed files with 6 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
services/core/java/com/android/server/wm/RemoteAnimationController.java
View File

@@ -70,6 +70,7 @@ class RemoteAnimationController implements DeathRecipient {
final ArrayList<NonAppWindowAnimationAdapter> mPendingNonAppAnimations = new ArrayList<>(); final ArrayList<NonAppWindowAnimationAdapter> mPendingNonAppAnimations = new ArrayList<>();
private final Handler mHandler; private final Handler mHandler;
private final Runnable mTimeoutRunnable = () -> cancelAnimation("timeoutRunnable"); private final Runnable mTimeoutRunnable = () -> cancelAnimation("timeoutRunnable");
private boolean mIsFinishing;
private FinishedCallback mFinishedCallback; private FinishedCallback mFinishedCallback;
private boolean mCanceled; private boolean mCanceled;
@@ -260,6 +261,7 @@ class RemoteAnimationController implements DeathRecipient {
mPendingAnimations.size()); mPendingAnimations.size());
mHandler.removeCallbacks(mTimeoutRunnable); mHandler.removeCallbacks(mTimeoutRunnable);
synchronized (mService.mGlobalLock) { synchronized (mService.mGlobalLock) {
mIsFinishing = true;
unlinkToDeathOfRunner(); unlinkToDeathOfRunner();
releaseFinishedCallback(); releaseFinishedCallback();
mService.openSurfaceTransaction(); mService.openSurfaceTransaction();
@@ -304,6 +306,7 @@ class RemoteAnimationController implements DeathRecipient {
throw e; throw e;
} finally { } finally {
mService.closeSurfaceTransaction("RemoteAnimationController#finished"); mService.closeSurfaceTransaction("RemoteAnimationController#finished");
mIsFinishing = false;
} }
} }
// Reset input for all activities when the remote animation is finished. // Reset input for all activities when the remote animation is finished.
@@ -523,6 +526,9 @@ class RemoteAnimationController implements DeathRecipient {
@Override @Override
public void onAnimationCancelled(SurfaceControl animationLeash) { public void onAnimationCancelled(SurfaceControl animationLeash) {
if (mIsFinishing) {
return;
}
if (mRecord.mAdapter == this) { if (mRecord.mAdapter == this) {
mRecord.mAdapter = null; mRecord.mAdapter = null;
} else { } else {