From 8eda958ba6b753322a4ed42d85bfe4e2bbc14361 Mon Sep 17 00:00:00 2001 From: Ahmad Khalil Date: Fri, 19 May 2023 23:04:48 +0000 Subject: [PATCH] Fix long click crash. Fix: 279275858 Test: android.view.cts.ViewTest Change-Id: I4545db564a73f1127296262b071e082ec0c88ed1 --- core/java/android/view/View.java | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/core/java/android/view/View.java b/core/java/android/view/View.java index 003307db832a5..7bd022b71ffaf 100644 --- a/core/java/android/view/View.java +++ b/core/java/android/view/View.java @@ -7734,13 +7734,14 @@ public class View implements Drawable.Callback, KeyEvent.Callback, sendAccessibilityEvent(AccessibilityEvent.TYPE_VIEW_LONG_CLICKED); boolean handled = false; - final ListenerInfo li = mListenerInfo; + final OnLongClickListener listener = + mListenerInfo == null ? null : mListenerInfo.mOnLongClickListener; boolean shouldPerformHapticFeedback = true; - if (li != null && li.mOnLongClickListener != null) { - handled = li.mOnLongClickListener.onLongClick(View.this); + if (listener != null) { + handled = listener.onLongClick(View.this); if (handled) { - shouldPerformHapticFeedback = - li.mOnLongClickListener.onLongClickUseDefaultHapticFeedback(View.this); + shouldPerformHapticFeedback = listener.onLongClickUseDefaultHapticFeedback( + View.this); } } if (!handled) {