Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge "Add error log for when widget provider is null" into tm-qpr-dev

Browse Source
This commit is contained in:
TreeHugger Robot
2022-08-06 02:31:39 +00:00
committed by Android (Google) Code Review
parent 7c4684eec0 5363de2f63
commit 8ccd22f485
1 changed files with 10 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
services/appwidget/java/com/android/server/appwidget/AppWidgetServiceImpl.java
View File

@@ -1109,11 +1109,8 @@ class AppWidgetServiceImpl extends IAppWidgetService.Stub implements WidgetBacku
registerForBroadcastsLocked(provider, getWidgetIds(provider.widgets)); registerForBroadcastsLocked(provider, getWidgetIds(provider.widgets));
saveGroupStateAsync(userId); saveGroupStateAsync(userId);
if (DEBUG) {
Slog.i(TAG, "Bound widget " + appWidgetId + " to provider " + provider.id); Slog.i(TAG, "Bound widget " + appWidgetId + " to provider " + provider.id);
} }
}
return true; return true;
} }
@@ -4196,6 +4193,10 @@ class AppWidgetServiceImpl extends IAppWidgetService.Stub implements WidgetBacku
IAppWidgetHost callbacks; IAppWidgetHost callbacks;
boolean zombie; // if we're in safe mode, don't prune this just because nobody references it boolean zombie; // if we're in safe mode, don't prune this just because nobody references it
private static final boolean DEBUG = true;
private static final String TAG = "AppWidgetServiceHost";
int tag = TAG_UNDEFINED; // for use while saving state (the index) int tag = TAG_UNDEFINED; // for use while saving state (the index)
// Sequence no for the last update successfully sent. This is updated whenever a // Sequence no for the last update successfully sent. This is updated whenever a
// widget update is successfully sent to the host callbacks. As all new/undelivered updates // widget update is successfully sent to the host callbacks. As all new/undelivered updates
@@ -4266,6 +4267,11 @@ class AppWidgetServiceImpl extends IAppWidgetService.Stub implements WidgetBacku
final SparseArray<String> uids = new SparseArray<>(); final SparseArray<String> uids = new SparseArray<>();
for (int i = widgets.size() - 1; i >= 0; i--) { for (int i = widgets.size() - 1; i >= 0; i--) {
final Widget widget = widgets.get(i); final Widget widget = widgets.get(i);
if (widget.provider == null) {
if (DEBUG) {
Slog.e(TAG, "Widget with no provider " + widget.toString());
}
}
final ProviderId providerId = widget.provider.id; final ProviderId providerId = widget.provider.id;
uids.put(providerId.uid, providerId.componentName.getPackageName()); uids.put(providerId.uid, providerId.componentName.getPackageName());
} }