Merge "Fix bad arguments handling"

am: 79a2b5215d

Change-Id: I903bc30acb4822b3df231be343ac9dbce7584661
This commit is contained in:
Tomasz Wasilczyk
2019-07-08 14:21:59 -07:00
committed by android-build-merger

View File

@@ -17,8 +17,6 @@
package com.android.server.net.watchlist; package com.android.server.net.watchlist;
import android.content.Context; import android.content.Context;
import android.content.Intent;
import android.net.NetworkWatchlistManager;
import android.os.Binder; import android.os.Binder;
import android.os.ParcelFileDescriptor; import android.os.ParcelFileDescriptor;
import android.os.RemoteException; import android.os.RemoteException;
@@ -26,7 +24,6 @@ import android.os.ShellCommand;
import android.provider.Settings; import android.provider.Settings;
import java.io.FileInputStream; import java.io.FileInputStream;
import java.io.IOException;
import java.io.InputStream; import java.io.InputStream;
import java.io.PrintWriter; import java.io.PrintWriter;
@@ -74,10 +71,12 @@ class NetworkWatchlistShellCommand extends ShellCommand {
try { try {
final String configXmlPath = getNextArgRequired(); final String configXmlPath = getNextArgRequired();
final ParcelFileDescriptor pfd = openFileForSystem(configXmlPath, "r"); final ParcelFileDescriptor pfd = openFileForSystem(configXmlPath, "r");
if (pfd != null) { if (pfd == null) {
final InputStream fileStream = new FileInputStream(pfd.getFileDescriptor()); pw.println("Error: can't open input file " + configXmlPath);
WatchlistConfig.getInstance().setTestMode(fileStream); return -1;
} }
final InputStream fileStream = new FileInputStream(pfd.getFileDescriptor());
WatchlistConfig.getInstance().setTestMode(fileStream);
pw.println("Success!"); pw.println("Success!");
} catch (Exception ex) { } catch (Exception ex) {
pw.println("Error: " + ex.toString()); pw.println("Error: " + ex.toString());