From 8be5ea3bdb3dfe98ee1cd5cdaa26290b79bc3d90 Mon Sep 17 00:00:00 2001 From: Craig Mautner Date: Tue, 2 Apr 2013 22:37:45 -0700 Subject: [PATCH] Perform activityIdleInternal in correct order. Refactor of ActivityManagerService.activityIdle left activityIdleInternalLocked called only if stopProfiling was true. Calling it in all situations is the correct behavior. Fixes bug 8532130. Change-Id: Ibd7f112bab104094ff1b1f3a2fb8c03b527ec453 --- .../com/android/server/am/ActivityManagerService.java | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/services/java/com/android/server/am/ActivityManagerService.java b/services/java/com/android/server/am/ActivityManagerService.java index de3d09fdeb7d0..d7a97c02c1a29 100644 --- a/services/java/com/android/server/am/ActivityManagerService.java +++ b/services/java/com/android/server/am/ActivityManagerService.java @@ -4371,11 +4371,11 @@ public final class ActivityManagerService extends ActivityManagerNative @Override public final void activityIdle(IBinder token, Configuration config, boolean stopProfiling) { final long origId = Binder.clearCallingIdentity(); - if (stopProfiling) { - synchronized (this) { - ActivityStack stack = ActivityRecord.getStackLocked(token); - if (stack != null) { - ActivityRecord r = stack.activityIdleInternalLocked(token, false, config); + synchronized (this) { + ActivityStack stack = ActivityRecord.getStackLocked(token); + if (stack != null) { + ActivityRecord r = stack.activityIdleInternalLocked(token, false, config); + if (stopProfiling) { if ((mProfileProc == r.app) && (mProfileFd != null)) { try { mProfileFd.close();