Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Delete premature optimization.

Browse Source 
This is part of a series of changes to improve input system pipelining.

Bug: 5963420

Change-Id: I5c182f6e17d468bf3033125b2094b2baa5b94e81
This commit is contained in:
Jeff Brown
2012-02-06 16:31:05 -08:00
parent 28b5cf1c33
commit 8b4be56030
2 changed files with 6 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
services/input/InputDispatcher.cpp
View File

@@ -2076,19 +2076,19 @@ void InputDispatcher::synthesizeCancelationEventsForConnectionLocked(
nsecs_t currentTime = now(); nsecs_t currentTime = now();
mTempCancelationEvents.clear(); Vector<EventEntry*> cancelationEvents;
connection->inputState.synthesizeCancelationEvents(currentTime, connection->inputState.synthesizeCancelationEvents(currentTime,
mTempCancelationEvents, options); cancelationEvents, options);
if (!mTempCancelationEvents.isEmpty()) { if (!cancelationEvents.isEmpty()) {
#if DEBUG_OUTBOUND_EVENT_DETAILS #if DEBUG_OUTBOUND_EVENT_DETAILS
ALOGD("channel '%s' ~ Synthesized %d cancelation events to bring channel back in sync " ALOGD("channel '%s' ~ Synthesized %d cancelation events to bring channel back in sync "
"with reality: %s, mode=%d.", "with reality: %s, mode=%d.",
connection->getInputChannelName(), mTempCancelationEvents.size(), connection->getInputChannelName(), cancelationEvents.size(),
options.reason, options.mode); options.reason, options.mode);
#endif #endif
for (size_t i = 0; i < mTempCancelationEvents.size(); i++) { for (size_t i = 0; i < cancelationEvents.size(); i++) {
EventEntry* cancelationEventEntry = mTempCancelationEvents.itemAt(i); EventEntry* cancelationEventEntry = cancelationEvents.itemAt(i);
switch (cancelationEventEntry->type) { switch (cancelationEventEntry->type) {
case EventEntry::TYPE_KEY: case EventEntry::TYPE_KEY:
logOutboundKeyDetailsLocked("cancel - ", logOutboundKeyDetailsLocked("cancel - ",

2
services/input/InputDispatcher.h
View File

@@ -814,8 +814,6 @@ private:
Queue<EventEntry> mInboundQueue; Queue<EventEntry> mInboundQueue;
Queue<CommandEntry> mCommandQueue; Queue<CommandEntry> mCommandQueue;
Vector<EventEntry*> mTempCancelationEvents;
void dispatchOnceInnerLocked(nsecs_t* nextWakeupTime); void dispatchOnceInnerLocked(nsecs_t* nextWakeupTime);
// Enqueues an inbound event. Returns true if mLooper->wake() should be called. // Enqueues an inbound event. Returns true if mLooper->wake() should be called.