From f560cfa220d19449ba470a9ad6c6d741dd6dc567 Mon Sep 17 00:00:00 2001 From: Weng Su Date: Tue, 25 Jan 2022 16:07:56 +0800 Subject: [PATCH] Fix ConnectivityPreferenceControllerTest failures - Security team add new parameter to registerReceiver() for security design. - Update the test case with the new parameters added. Bug: 215311415 Test: manual test make RunSettingsLibRoboTests ROBOTEST_FILTER=ConnectivityPreferenceControllerTest Change-Id: If68a5faf08b938b9b7ea26389d84b04e915f8811 --- .../deviceinfo/ConnectivityPreferenceControllerTest.java | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/packages/SettingsLib/tests/robotests/src/com/android/settingslib/deviceinfo/ConnectivityPreferenceControllerTest.java b/packages/SettingsLib/tests/robotests/src/com/android/settingslib/deviceinfo/ConnectivityPreferenceControllerTest.java index c1cc3ae9778ad..445701fa72445 100644 --- a/packages/SettingsLib/tests/robotests/src/com/android/settingslib/deviceinfo/ConnectivityPreferenceControllerTest.java +++ b/packages/SettingsLib/tests/robotests/src/com/android/settingslib/deviceinfo/ConnectivityPreferenceControllerTest.java @@ -18,6 +18,7 @@ package com.android.settingslib.deviceinfo; import static com.google.common.truth.Truth.assertWithMessage; +import static org.mockito.ArgumentMatchers.anyInt; import static org.mockito.ArgumentMatchers.anyString; import static org.mockito.ArgumentMatchers.nullable; import static org.mockito.Mockito.doReturn; @@ -33,7 +34,6 @@ import android.os.Handler; import com.android.settingslib.core.lifecycle.Lifecycle; import org.junit.Before; -import org.junit.Ignore; import org.junit.Test; import org.junit.runner.RunWith; import org.mockito.ArgumentCaptor; @@ -55,7 +55,6 @@ public class ConnectivityPreferenceControllerTest { } @Test - @Ignore public void testBroadcastReceiver() { final AbstractConnectivityPreferenceController preferenceController = spy(new ConcreteConnectivityPreferenceController(mContext, mLifecycle)); @@ -73,7 +72,7 @@ public class ConnectivityPreferenceControllerTest { verify(mContext, times(1)) .registerReceiver(receiverArgumentCaptor.capture(), filterArgumentCaptor.capture(), - anyString(), nullable(Handler.class)); + anyString(), nullable(Handler.class), anyInt()); final BroadcastReceiver receiver = receiverArgumentCaptor.getValue(); final IntentFilter filter = filterArgumentCaptor.getValue();