Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge "Fix potential NPE when removing bubble" into udc-dev

Browse Source
This commit is contained in:
Mady Mellor
2023-05-12 00:42:21 +00:00
committed by Android (Google) Code Review
parent 071795c050 a9f16586c4
commit 8afb4df8dd
1 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
libs/WindowManager/Shell/src/com/android/wm/shell/bubbles/BubbleStackView.java
View File

@@ -1784,10 +1784,13 @@ public class BubbleStackView extends FrameLayout
// We're expanded while the last bubble is being removed. Let the scrim animate away // We're expanded while the last bubble is being removed. Let the scrim animate away
// and then remove our views (removing the icon view triggers the removal of the // and then remove our views (removing the icon view triggers the removal of the
// bubble window so do that at the end of the animation so we see the scrim animate). // bubble window so do that at the end of the animation so we see the scrim animate).
BadgedImageView iconView = bubble.getIconView();
showScrim(false, () -> { showScrim(false, () -> {
mRemovingLastBubbleWhileExpanded = false; mRemovingLastBubbleWhileExpanded = false;
bubble.cleanupExpandedView(); bubble.cleanupExpandedView();
mBubbleContainer.removeView(bubble.getIconView()); if (iconView != null) {
mBubbleContainer.removeView(iconView);
}
bubble.cleanupViews(); // cleans up the icon view bubble.cleanupViews(); // cleans up the icon view
updateExpandedView(); // resets state for no expanded bubble updateExpandedView(); // resets state for no expanded bubble
}); });