Merge "Avoid unnecessary dup" am: c333d989d8

Original change: https://android-review.googlesource.com/c/platform/frameworks/base/+/1869046

Change-Id: I69cb891334a7b02714d84a040c0bf4f07adfd03a
This commit is contained in:
Ytai Ben-tsvi
2021-10-25 21:04:59 +00:00
committed by Automerger Merge Worker

View File

@@ -429,15 +429,7 @@ class ConversionUtil {
private static @NonNull private static @NonNull
HidlMemory parcelFileDescriptorToHidlMemory(@Nullable ParcelFileDescriptor data, int dataSize) { HidlMemory parcelFileDescriptorToHidlMemory(@Nullable ParcelFileDescriptor data, int dataSize) {
if (dataSize > 0) { if (dataSize > 0) {
// Extract a dup of the underlying FileDescriptor out of data. return HidlMemoryUtil.fileDescriptorToHidlMemory(data.getFileDescriptor(), dataSize);
FileDescriptor fd = new FileDescriptor();
try {
ParcelFileDescriptor dup = data.dup();
fd.setInt$(dup.detachFd());
return HidlMemoryUtil.fileDescriptorToHidlMemory(fd, dataSize);
} catch (IOException e) {
throw new RuntimeException(e);
}
} else { } else {
return HidlMemoryUtil.fileDescriptorToHidlMemory(null, 0); return HidlMemoryUtil.fileDescriptorToHidlMemory(null, 0);
} }