From 8a40ff855b86bc86e23367017002289920855a4e Mon Sep 17 00:00:00 2001 From: Lucas Dupin Date: Wed, 2 Jun 2021 16:32:22 -0700 Subject: [PATCH] Do not re-inflate QS and SB when CONFIG_UI_MODE FragmentHostManager has 2 clients: - CollapsedStatusBarFragment - QSFragment None of them respond to dark theme changes because: - SB has its own color management queue - QSFragment always has dark theme in S This drastically reduces the amount of jank when siwtching themes, because tiles won't be re-created anymore. Test: toggle dark theme from QS, open various apps Test: toggle dark theme from Settings app Bug: 185403130 Change-Id: I95ed3e586050d12d571877d0a058714fb011b6fc --- .../com/android/systemui/fragments/FragmentHostManager.java | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/packages/SystemUI/src/com/android/systemui/fragments/FragmentHostManager.java b/packages/SystemUI/src/com/android/systemui/fragments/FragmentHostManager.java index 87d90adceba52..b45dc52585ad9 100644 --- a/packages/SystemUI/src/com/android/systemui/fragments/FragmentHostManager.java +++ b/packages/SystemUI/src/com/android/systemui/fragments/FragmentHostManager.java @@ -54,8 +54,7 @@ public class FragmentHostManager { private final View mRootView; private final InterestingConfigChanges mConfigChanges = new InterestingConfigChanges( ActivityInfo.CONFIG_FONT_SCALE | ActivityInfo.CONFIG_LOCALE - | ActivityInfo.CONFIG_SCREEN_LAYOUT | ActivityInfo.CONFIG_ASSETS_PATHS - | ActivityInfo.CONFIG_UI_MODE); + | ActivityInfo.CONFIG_SCREEN_LAYOUT | ActivityInfo.CONFIG_ASSETS_PATHS); private final FragmentService mManager; private final ExtensionFragmentManager mPlugins = new ExtensionFragmentManager();