From d8a5777bf87555979b3f8297cb3cdccb9e34a4cd Mon Sep 17 00:00:00 2001 From: Jorim Jaggi Date: Fri, 14 Apr 2017 16:50:42 -0700 Subject: [PATCH] Insert missing breaks Found you! Test: Go multi-window, go fullscreen, hammer home button Change-Id: I019d89b95588ab2a0e33d9ef2bdc7240111162d0 Fixes: 36339388 --- .../core/java/com/android/server/am/ActivityMetricsLogger.java | 3 +-- .../core/java/com/android/server/wm/WindowManagerService.java | 3 +++ 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/services/core/java/com/android/server/am/ActivityMetricsLogger.java b/services/core/java/com/android/server/am/ActivityMetricsLogger.java index 494aaa766b94a..08ff7de87c9fb 100644 --- a/services/core/java/com/android/server/am/ActivityMetricsLogger.java +++ b/services/core/java/com/android/server/am/ActivityMetricsLogger.java @@ -254,8 +254,7 @@ class ActivityMetricsLogger { * ActivityManagerInternal.APP_TRANSITION_* reasons. */ void notifyTransitionStarting(SparseIntArray stackIdReasons) { - // TODO (b/36339388): Figure out why stackIdReasons can be null - if (stackIdReasons == null || !isAnyTransitionActive() || mLoggedTransitionStarting) { + if (!isAnyTransitionActive() || mLoggedTransitionStarting) { return; } mCurrentTransitionDelayMs = calculateCurrentDelay(); diff --git a/services/core/java/com/android/server/wm/WindowManagerService.java b/services/core/java/com/android/server/wm/WindowManagerService.java index 252b4d4e0473a..ef13924658a91 100644 --- a/services/core/java/com/android/server/wm/WindowManagerService.java +++ b/services/core/java/com/android/server/wm/WindowManagerService.java @@ -5035,6 +5035,7 @@ public class WindowManagerService extends IWindowManager.Stub if (callback != null) { callback.run(); } + break; } case NEW_ANIMATOR_SCALE: { float scale = getCurrentAnimatorScale(); @@ -5087,6 +5088,7 @@ public class WindowManagerService extends IWindowManager.Stub } } } + break; case UPDATE_DOCKED_STACK_DIVIDER: { synchronized (mWindowMap) { final DisplayContent displayContent = getDefaultDisplayContentLocked(); @@ -5104,6 +5106,7 @@ public class WindowManagerService extends IWindowManager.Stub mWindowReplacementTimeouts.clear(); } } + break; case NOTIFY_APP_TRANSITION_STARTING: { mAmInternal.notifyAppTransitionStarting((SparseIntArray) msg.obj); }