From 05f95dcaa7d209e1336624f1b33c6798f5323777 Mon Sep 17 00:00:00 2001 From: Santiago Seifert Date: Wed, 3 Nov 2021 12:12:04 +0000 Subject: [PATCH] Replace new with sp<>::make As per sp's recommendations. Bug: 204401299 Change-Id: Ida464b7ef44e2ad5855764e4e7d03b9f6bd5d1b0 Test: Built and flashed device. Test: atest CtsMediaTestCases:MediaPlayerTest --- media/jni/android_media_MediaPlayer.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/media/jni/android_media_MediaPlayer.cpp b/media/jni/android_media_MediaPlayer.cpp index 2636ab2276467..8dcdc989ec8fe 100644 --- a/media/jni/android_media_MediaPlayer.cpp +++ b/media/jni/android_media_MediaPlayer.cpp @@ -953,7 +953,7 @@ android_media_MediaPlayer_native_setup(JNIEnv *env, jobject thiz, jobject weak_t Parcel* parcel = parcelForJavaObject(env, jAttributionSource); android::content::AttributionSourceState attributionSource; attributionSource.readFromParcel(parcel); - sp mp = new MediaPlayer(attributionSource); + sp mp = sp::make(attributionSource); if (mp == NULL) { jniThrowException(env, "java/lang/RuntimeException", "Out of memory"); return;