From 259ca1ec6188caeaac440c0fc63698360ce7f890 Mon Sep 17 00:00:00 2001 From: Eran Messeri Date: Wed, 9 Mar 2022 11:03:12 +0000 Subject: [PATCH] Do not register Curve25519 as a key factory directly Do not register Curve 25519 algorithms as key factories, until we fix the registration to be in compliance with JEP 324. Bug: 222440855 Bug: 222194540 Test: atest android.keystore.cts.Curve25519Test android.keystore.cts.KeyFactoryTest#testAlgorithmList CtsLibcoreTestCases:libcore.java.security.ProviderTest#test_Provider_getServices Merged-In: Ibd53070a890955affaff5e4e7213892afd423db7 Change-Id: I11b3574aeff54b3eb8bf496c4c14aa1338629ce5 --- .../android/security/keystore2/AndroidKeyStoreProvider.java | 6 ------ 1 file changed, 6 deletions(-) diff --git a/keystore/java/android/security/keystore2/AndroidKeyStoreProvider.java b/keystore/java/android/security/keystore2/AndroidKeyStoreProvider.java index 358104fffbf6a..e5d127609b2ed 100644 --- a/keystore/java/android/security/keystore2/AndroidKeyStoreProvider.java +++ b/keystore/java/android/security/keystore2/AndroidKeyStoreProvider.java @@ -83,16 +83,10 @@ public class AndroidKeyStoreProvider extends Provider { // java.security.KeyPairGenerator put("KeyPairGenerator.EC", PACKAGE_NAME + ".AndroidKeyStoreKeyPairGeneratorSpi$EC"); put("KeyPairGenerator.RSA", PACKAGE_NAME + ".AndroidKeyStoreKeyPairGeneratorSpi$RSA"); - put("KeyPairGenerator." + X25519_ALIAS, - PACKAGE_NAME + ".AndroidKeyStoreKeyPairGeneratorSpi$RSA"); - put("KeyPairGenerator." + ED25519_OID, - PACKAGE_NAME + ".AndroidKeyStoreKeyPairGeneratorSpi$RSA"); // java.security.KeyFactory putKeyFactoryImpl("EC"); putKeyFactoryImpl("RSA"); - putKeyFactoryImpl(X25519_ALIAS); - putKeyFactoryImpl(ED25519_OID); // javax.crypto.KeyGenerator put("KeyGenerator.AES", PACKAGE_NAME + ".AndroidKeyStoreKeyGeneratorSpi$AES");