From 87a4ad07d2c8d8088e78e8770bae3a3130625d14 Mon Sep 17 00:00:00 2001 From: Atneya Nair Date: Wed, 26 Apr 2023 19:14:29 -0700 Subject: [PATCH] Remove RECORD_AUDIO requirement for ST listModules No reason to require RECORD pre-flight permissions to query dsp module properties. CAPTURE_AUDIO_HOTWORD, which is a non-runtime permission, should suffice to ensure only valid ST clients can call this method. We will still require RECORD for the rest of the methods, which actually begin to interact with the hardware. Bug: 272147641 Fixes: 279839210 Test: SoundTriggerManagerTest Change-Id: Ibf61fe8f26169dff754dbd40f385793b325707de --- .../SoundTriggerMiddlewarePermission.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/services/voiceinteraction/java/com/android/server/soundtrigger_middleware/SoundTriggerMiddlewarePermission.java b/services/voiceinteraction/java/com/android/server/soundtrigger_middleware/SoundTriggerMiddlewarePermission.java index 13fe14caa1f99..00cedd77414e6 100644 --- a/services/voiceinteraction/java/com/android/server/soundtrigger_middleware/SoundTriggerMiddlewarePermission.java +++ b/services/voiceinteraction/java/com/android/server/soundtrigger_middleware/SoundTriggerMiddlewarePermission.java @@ -78,7 +78,7 @@ public class SoundTriggerMiddlewarePermission implements ISoundTriggerMiddleware public @NonNull SoundTriggerModuleDescriptor[] listModules() { Identity identity = getIdentity(); - enforcePermissionsForPreflight(identity); + enforcePermissionForPreflight(mContext, identity, CAPTURE_AUDIO_HOTWORD); return mDelegate.listModules(); }