From d64e6269daa6eaf3aba7b843e606d87cc80153bc Mon Sep 17 00:00:00 2001 From: Amin Shaikh Date: Thu, 8 Mar 2018 10:08:13 -0500 Subject: [PATCH] Display mobile data type icons in status bar. Instead of showing the type in the top left corner of the signal. - Add new status bar mobile data indicator assets - Remove unused qs/status bar mobile data indicator assets Bug: 72540392 Test: visual using demo mode Change-Id: Ic63ad3307daabf2e0f023308b7e0682dbd29f1ca --- .../res/anim/ic_qs_signal_blink_1.xml | 38 --------- .../res/anim/ic_qs_signal_blink_2.xml | 44 ---------- .../res/anim/ic_qs_signal_blink_3.xml | 38 --------- .../res/drawable/ic_1x_mobiledata.xml | 29 +++++++ .../res/drawable/ic_3g_mobiledata.xml | 29 +++++++ .../res/drawable/ic_4g_mobiledata.xml | 29 +++++++ .../res/drawable/ic_4g_plus_mobiledata.xml | 29 +++++++ .../SystemUI/res/drawable/ic_e_mobiledata.xml | 29 +++++++ .../SystemUI/res/drawable/ic_g_mobiledata.xml | 29 +++++++ .../SystemUI/res/drawable/ic_h_mobiledata.xml | 29 +++++++ .../res/drawable/ic_h_plus_mobiledata.xml | 32 ++++++++ .../res/drawable/ic_lte_mobiledata.xml | 29 +++++++ .../res/drawable/ic_lte_plus_mobiledata.xml | 29 +++++++ .../SystemUI/res/drawable/ic_qs_signal_0.xml | 29 ------- .../SystemUI/res/drawable/ic_qs_signal_1x.xml | 28 ------- .../SystemUI/res/drawable/ic_qs_signal_3g.xml | 28 ------- .../SystemUI/res/drawable/ic_qs_signal_4g.xml | 28 ------- .../res/drawable/ic_qs_signal_4g_plus.xml | 31 ------- .../res/drawable/ic_qs_signal_disabled.xml | 29 ------- .../SystemUI/res/drawable/ic_qs_signal_e.xml | 28 ------- .../SystemUI/res/drawable/ic_qs_signal_g.xml | 27 ------- .../SystemUI/res/drawable/ic_qs_signal_h.xml | 28 ------- .../res/drawable/ic_qs_signal_lte.xml | 31 ------- .../res/drawable/ic_qs_signal_lte_plus.xml | 34 -------- .../res/drawable/ic_qs_signal_no_signal.xml | 25 ------ .../stat_sys_data_fully_connected_1x.xml | 27 ------- .../stat_sys_data_fully_connected_3g.xml | 27 ------- .../stat_sys_data_fully_connected_4g.xml | 27 ------- .../stat_sys_data_fully_connected_4g_plus.xml | 30 ------- .../stat_sys_data_fully_connected_e.xml | 24 ------ .../stat_sys_data_fully_connected_g.xml | 24 ------ .../stat_sys_data_fully_connected_h.xml | 24 ------ .../stat_sys_data_fully_connected_lte.xml | 30 ------- ...stat_sys_data_fully_connected_lte_plus.xml | 33 -------- .../res/layout/mobile_signal_group.xml | 21 ++--- .../policy/MobileSignalController.java | 5 +- .../statusbar/policy/TelephonyIcons.java | 81 ++++++------------- .../statusbar/policy/CallbackHandlerTest.java | 4 +- .../policy/NetworkControllerBaseTest.java | 2 +- .../policy/NetworkControllerDataTest.java | 43 ++++------ .../policy/NetworkControllerSignalTest.java | 2 +- 41 files changed, 350 insertions(+), 813 deletions(-) delete mode 100644 packages/SystemUI/res/anim/ic_qs_signal_blink_1.xml delete mode 100644 packages/SystemUI/res/anim/ic_qs_signal_blink_2.xml delete mode 100644 packages/SystemUI/res/anim/ic_qs_signal_blink_3.xml create mode 100644 packages/SystemUI/res/drawable/ic_1x_mobiledata.xml create mode 100644 packages/SystemUI/res/drawable/ic_3g_mobiledata.xml create mode 100644 packages/SystemUI/res/drawable/ic_4g_mobiledata.xml create mode 100644 packages/SystemUI/res/drawable/ic_4g_plus_mobiledata.xml create mode 100644 packages/SystemUI/res/drawable/ic_e_mobiledata.xml create mode 100644 packages/SystemUI/res/drawable/ic_g_mobiledata.xml create mode 100644 packages/SystemUI/res/drawable/ic_h_mobiledata.xml create mode 100644 packages/SystemUI/res/drawable/ic_h_plus_mobiledata.xml create mode 100644 packages/SystemUI/res/drawable/ic_lte_mobiledata.xml create mode 100644 packages/SystemUI/res/drawable/ic_lte_plus_mobiledata.xml delete mode 100644 packages/SystemUI/res/drawable/ic_qs_signal_0.xml delete mode 100644 packages/SystemUI/res/drawable/ic_qs_signal_1x.xml delete mode 100644 packages/SystemUI/res/drawable/ic_qs_signal_3g.xml delete mode 100644 packages/SystemUI/res/drawable/ic_qs_signal_4g.xml delete mode 100644 packages/SystemUI/res/drawable/ic_qs_signal_4g_plus.xml delete mode 100644 packages/SystemUI/res/drawable/ic_qs_signal_disabled.xml delete mode 100644 packages/SystemUI/res/drawable/ic_qs_signal_e.xml delete mode 100644 packages/SystemUI/res/drawable/ic_qs_signal_g.xml delete mode 100644 packages/SystemUI/res/drawable/ic_qs_signal_h.xml delete mode 100644 packages/SystemUI/res/drawable/ic_qs_signal_lte.xml delete mode 100644 packages/SystemUI/res/drawable/ic_qs_signal_lte_plus.xml delete mode 100644 packages/SystemUI/res/drawable/ic_qs_signal_no_signal.xml delete mode 100644 packages/SystemUI/res/drawable/stat_sys_data_fully_connected_1x.xml delete mode 100644 packages/SystemUI/res/drawable/stat_sys_data_fully_connected_3g.xml delete mode 100644 packages/SystemUI/res/drawable/stat_sys_data_fully_connected_4g.xml delete mode 100644 packages/SystemUI/res/drawable/stat_sys_data_fully_connected_4g_plus.xml delete mode 100644 packages/SystemUI/res/drawable/stat_sys_data_fully_connected_e.xml delete mode 100644 packages/SystemUI/res/drawable/stat_sys_data_fully_connected_g.xml delete mode 100644 packages/SystemUI/res/drawable/stat_sys_data_fully_connected_h.xml delete mode 100644 packages/SystemUI/res/drawable/stat_sys_data_fully_connected_lte.xml delete mode 100644 packages/SystemUI/res/drawable/stat_sys_data_fully_connected_lte_plus.xml diff --git a/packages/SystemUI/res/anim/ic_qs_signal_blink_1.xml b/packages/SystemUI/res/anim/ic_qs_signal_blink_1.xml deleted file mode 100644 index 57b61da4dfab4..0000000000000 --- a/packages/SystemUI/res/anim/ic_qs_signal_blink_1.xml +++ /dev/null @@ -1,38 +0,0 @@ - - - - - - - - - - - diff --git a/packages/SystemUI/res/anim/ic_qs_signal_blink_2.xml b/packages/SystemUI/res/anim/ic_qs_signal_blink_2.xml deleted file mode 100644 index 09694c3ec308d..0000000000000 --- a/packages/SystemUI/res/anim/ic_qs_signal_blink_2.xml +++ /dev/null @@ -1,44 +0,0 @@ - - - - - - - - - - - - - diff --git a/packages/SystemUI/res/anim/ic_qs_signal_blink_3.xml b/packages/SystemUI/res/anim/ic_qs_signal_blink_3.xml deleted file mode 100644 index 2270e3f9ce9de..0000000000000 --- a/packages/SystemUI/res/anim/ic_qs_signal_blink_3.xml +++ /dev/null @@ -1,38 +0,0 @@ - - - - - - - - - - - diff --git a/packages/SystemUI/res/drawable/ic_1x_mobiledata.xml b/packages/SystemUI/res/drawable/ic_1x_mobiledata.xml new file mode 100644 index 0000000000000..382d9d59a441c --- /dev/null +++ b/packages/SystemUI/res/drawable/ic_1x_mobiledata.xml @@ -0,0 +1,29 @@ + + + + + + + diff --git a/packages/SystemUI/res/drawable/ic_3g_mobiledata.xml b/packages/SystemUI/res/drawable/ic_3g_mobiledata.xml new file mode 100644 index 0000000000000..ce003e4719fb4 --- /dev/null +++ b/packages/SystemUI/res/drawable/ic_3g_mobiledata.xml @@ -0,0 +1,29 @@ + + + + + + + diff --git a/packages/SystemUI/res/drawable/ic_4g_mobiledata.xml b/packages/SystemUI/res/drawable/ic_4g_mobiledata.xml new file mode 100644 index 0000000000000..8e22e069d4500 --- /dev/null +++ b/packages/SystemUI/res/drawable/ic_4g_mobiledata.xml @@ -0,0 +1,29 @@ + + + + + + + diff --git a/packages/SystemUI/res/drawable/ic_4g_plus_mobiledata.xml b/packages/SystemUI/res/drawable/ic_4g_plus_mobiledata.xml new file mode 100644 index 0000000000000..32add0c54b736 --- /dev/null +++ b/packages/SystemUI/res/drawable/ic_4g_plus_mobiledata.xml @@ -0,0 +1,29 @@ + + + + + + + diff --git a/packages/SystemUI/res/drawable/ic_e_mobiledata.xml b/packages/SystemUI/res/drawable/ic_e_mobiledata.xml new file mode 100644 index 0000000000000..80e507b0a67a0 --- /dev/null +++ b/packages/SystemUI/res/drawable/ic_e_mobiledata.xml @@ -0,0 +1,29 @@ + + + + + + + diff --git a/packages/SystemUI/res/drawable/ic_g_mobiledata.xml b/packages/SystemUI/res/drawable/ic_g_mobiledata.xml new file mode 100644 index 0000000000000..04049ced5eea8 --- /dev/null +++ b/packages/SystemUI/res/drawable/ic_g_mobiledata.xml @@ -0,0 +1,29 @@ + + + + + + + diff --git a/packages/SystemUI/res/drawable/ic_h_mobiledata.xml b/packages/SystemUI/res/drawable/ic_h_mobiledata.xml new file mode 100644 index 0000000000000..31cc4a7b85400 --- /dev/null +++ b/packages/SystemUI/res/drawable/ic_h_mobiledata.xml @@ -0,0 +1,29 @@ + + + + + + + diff --git a/packages/SystemUI/res/drawable/ic_h_plus_mobiledata.xml b/packages/SystemUI/res/drawable/ic_h_plus_mobiledata.xml new file mode 100644 index 0000000000000..ca1020e91ad9e --- /dev/null +++ b/packages/SystemUI/res/drawable/ic_h_plus_mobiledata.xml @@ -0,0 +1,32 @@ + + + + + + + + diff --git a/packages/SystemUI/res/drawable/ic_lte_mobiledata.xml b/packages/SystemUI/res/drawable/ic_lte_mobiledata.xml new file mode 100644 index 0000000000000..5d909654c1fb0 --- /dev/null +++ b/packages/SystemUI/res/drawable/ic_lte_mobiledata.xml @@ -0,0 +1,29 @@ + + + + + + + diff --git a/packages/SystemUI/res/drawable/ic_lte_plus_mobiledata.xml b/packages/SystemUI/res/drawable/ic_lte_plus_mobiledata.xml new file mode 100644 index 0000000000000..0366e24b1998e --- /dev/null +++ b/packages/SystemUI/res/drawable/ic_lte_plus_mobiledata.xml @@ -0,0 +1,29 @@ + + + + + + + diff --git a/packages/SystemUI/res/drawable/ic_qs_signal_0.xml b/packages/SystemUI/res/drawable/ic_qs_signal_0.xml deleted file mode 100644 index b78d3bf1c35de..0000000000000 --- a/packages/SystemUI/res/drawable/ic_qs_signal_0.xml +++ /dev/null @@ -1,29 +0,0 @@ - - - - - diff --git a/packages/SystemUI/res/drawable/ic_qs_signal_1x.xml b/packages/SystemUI/res/drawable/ic_qs_signal_1x.xml deleted file mode 100644 index 5217748bbc838..0000000000000 --- a/packages/SystemUI/res/drawable/ic_qs_signal_1x.xml +++ /dev/null @@ -1,28 +0,0 @@ - - - - - diff --git a/packages/SystemUI/res/drawable/ic_qs_signal_3g.xml b/packages/SystemUI/res/drawable/ic_qs_signal_3g.xml deleted file mode 100644 index 546a96f617cfc..0000000000000 --- a/packages/SystemUI/res/drawable/ic_qs_signal_3g.xml +++ /dev/null @@ -1,28 +0,0 @@ - - - - - diff --git a/packages/SystemUI/res/drawable/ic_qs_signal_4g.xml b/packages/SystemUI/res/drawable/ic_qs_signal_4g.xml deleted file mode 100644 index 26b68c7b1e5ab..0000000000000 --- a/packages/SystemUI/res/drawable/ic_qs_signal_4g.xml +++ /dev/null @@ -1,28 +0,0 @@ - - - - - diff --git a/packages/SystemUI/res/drawable/ic_qs_signal_4g_plus.xml b/packages/SystemUI/res/drawable/ic_qs_signal_4g_plus.xml deleted file mode 100644 index 6e4b4c563fcf7..0000000000000 --- a/packages/SystemUI/res/drawable/ic_qs_signal_4g_plus.xml +++ /dev/null @@ -1,31 +0,0 @@ - - - - - - diff --git a/packages/SystemUI/res/drawable/ic_qs_signal_disabled.xml b/packages/SystemUI/res/drawable/ic_qs_signal_disabled.xml deleted file mode 100644 index c841a66fa8f40..0000000000000 --- a/packages/SystemUI/res/drawable/ic_qs_signal_disabled.xml +++ /dev/null @@ -1,29 +0,0 @@ - - - - - diff --git a/packages/SystemUI/res/drawable/ic_qs_signal_e.xml b/packages/SystemUI/res/drawable/ic_qs_signal_e.xml deleted file mode 100644 index f4b6ed82f8b81..0000000000000 --- a/packages/SystemUI/res/drawable/ic_qs_signal_e.xml +++ /dev/null @@ -1,28 +0,0 @@ - - - - - - diff --git a/packages/SystemUI/res/drawable/ic_qs_signal_g.xml b/packages/SystemUI/res/drawable/ic_qs_signal_g.xml deleted file mode 100644 index 60a7f1e9ad069..0000000000000 --- a/packages/SystemUI/res/drawable/ic_qs_signal_g.xml +++ /dev/null @@ -1,27 +0,0 @@ - - - - - - diff --git a/packages/SystemUI/res/drawable/ic_qs_signal_h.xml b/packages/SystemUI/res/drawable/ic_qs_signal_h.xml deleted file mode 100644 index 4ffb4be6e0a9f..0000000000000 --- a/packages/SystemUI/res/drawable/ic_qs_signal_h.xml +++ /dev/null @@ -1,28 +0,0 @@ - - - - - - diff --git a/packages/SystemUI/res/drawable/ic_qs_signal_lte.xml b/packages/SystemUI/res/drawable/ic_qs_signal_lte.xml deleted file mode 100644 index 816cd32220729..0000000000000 --- a/packages/SystemUI/res/drawable/ic_qs_signal_lte.xml +++ /dev/null @@ -1,31 +0,0 @@ - - - - - - diff --git a/packages/SystemUI/res/drawable/ic_qs_signal_lte_plus.xml b/packages/SystemUI/res/drawable/ic_qs_signal_lte_plus.xml deleted file mode 100644 index 4c43e13b1c660..0000000000000 --- a/packages/SystemUI/res/drawable/ic_qs_signal_lte_plus.xml +++ /dev/null @@ -1,34 +0,0 @@ - - - - - - - diff --git a/packages/SystemUI/res/drawable/ic_qs_signal_no_signal.xml b/packages/SystemUI/res/drawable/ic_qs_signal_no_signal.xml deleted file mode 100644 index c8c857c7ef0ca..0000000000000 --- a/packages/SystemUI/res/drawable/ic_qs_signal_no_signal.xml +++ /dev/null @@ -1,25 +0,0 @@ - - - - diff --git a/packages/SystemUI/res/drawable/stat_sys_data_fully_connected_1x.xml b/packages/SystemUI/res/drawable/stat_sys_data_fully_connected_1x.xml deleted file mode 100644 index d7463a446657e..0000000000000 --- a/packages/SystemUI/res/drawable/stat_sys_data_fully_connected_1x.xml +++ /dev/null @@ -1,27 +0,0 @@ - - - - - diff --git a/packages/SystemUI/res/drawable/stat_sys_data_fully_connected_3g.xml b/packages/SystemUI/res/drawable/stat_sys_data_fully_connected_3g.xml deleted file mode 100644 index 6309b6d9903be..0000000000000 --- a/packages/SystemUI/res/drawable/stat_sys_data_fully_connected_3g.xml +++ /dev/null @@ -1,27 +0,0 @@ - - - - - diff --git a/packages/SystemUI/res/drawable/stat_sys_data_fully_connected_4g.xml b/packages/SystemUI/res/drawable/stat_sys_data_fully_connected_4g.xml deleted file mode 100644 index 4067ae5b4800b..0000000000000 --- a/packages/SystemUI/res/drawable/stat_sys_data_fully_connected_4g.xml +++ /dev/null @@ -1,27 +0,0 @@ - - - - - diff --git a/packages/SystemUI/res/drawable/stat_sys_data_fully_connected_4g_plus.xml b/packages/SystemUI/res/drawable/stat_sys_data_fully_connected_4g_plus.xml deleted file mode 100644 index 719a6ca3b7e48..0000000000000 --- a/packages/SystemUI/res/drawable/stat_sys_data_fully_connected_4g_plus.xml +++ /dev/null @@ -1,30 +0,0 @@ - - - - - - diff --git a/packages/SystemUI/res/drawable/stat_sys_data_fully_connected_e.xml b/packages/SystemUI/res/drawable/stat_sys_data_fully_connected_e.xml deleted file mode 100644 index acaa9b1c2be8c..0000000000000 --- a/packages/SystemUI/res/drawable/stat_sys_data_fully_connected_e.xml +++ /dev/null @@ -1,24 +0,0 @@ - - - - diff --git a/packages/SystemUI/res/drawable/stat_sys_data_fully_connected_g.xml b/packages/SystemUI/res/drawable/stat_sys_data_fully_connected_g.xml deleted file mode 100644 index 7985237d8a446..0000000000000 --- a/packages/SystemUI/res/drawable/stat_sys_data_fully_connected_g.xml +++ /dev/null @@ -1,24 +0,0 @@ - - - - diff --git a/packages/SystemUI/res/drawable/stat_sys_data_fully_connected_h.xml b/packages/SystemUI/res/drawable/stat_sys_data_fully_connected_h.xml deleted file mode 100644 index fda87612582ed..0000000000000 --- a/packages/SystemUI/res/drawable/stat_sys_data_fully_connected_h.xml +++ /dev/null @@ -1,24 +0,0 @@ - - - - diff --git a/packages/SystemUI/res/drawable/stat_sys_data_fully_connected_lte.xml b/packages/SystemUI/res/drawable/stat_sys_data_fully_connected_lte.xml deleted file mode 100644 index c08ff20c54fc4..0000000000000 --- a/packages/SystemUI/res/drawable/stat_sys_data_fully_connected_lte.xml +++ /dev/null @@ -1,30 +0,0 @@ - - - - - - diff --git a/packages/SystemUI/res/drawable/stat_sys_data_fully_connected_lte_plus.xml b/packages/SystemUI/res/drawable/stat_sys_data_fully_connected_lte_plus.xml deleted file mode 100644 index 62159b3666494..0000000000000 --- a/packages/SystemUI/res/drawable/stat_sys_data_fully_connected_lte_plus.xml +++ /dev/null @@ -1,33 +0,0 @@ - - - - - - - diff --git a/packages/SystemUI/res/layout/mobile_signal_group.xml b/packages/SystemUI/res/layout/mobile_signal_group.xml index 3485b362480fa..2e92042cc1c26 100644 --- a/packages/SystemUI/res/layout/mobile_signal_group.xml +++ b/packages/SystemUI/res/layout/mobile_signal_group.xml @@ -22,11 +22,12 @@ android:id="@+id/mobile_combo" android:layout_width="wrap_content" android:layout_height="wrap_content" - android:orientation="horizontal" - > + android:layout_gravity="center_vertical" + android:orientation="horizontal"> + android:layout_width="wrap_content" + android:layout_gravity="center_vertical"> + + android:layout_height="wrap_content" + android:layout_gravity="center_vertical"> -