From c350b0492d2fd0bbd3a8fd7e2a2b1fa1852a315e Mon Sep 17 00:00:00 2001 From: Zoey Chen Date: Fri, 10 Dec 2021 13:56:16 +0800 Subject: [PATCH] [ProviderModel] Should no set the subtitle as gone when airplane mode is ON Test: manual, atest InternetDialogTest Bug: 209095671 Change-Id: I8837c3d20caaf509fae29c9c0a956a2c647a0d61 --- .../systemui/qs/tiles/dialog/InternetDialog.java | 14 +++++--------- .../qs/tiles/dialog/InternetDialogTest.java | 2 +- 2 files changed, 6 insertions(+), 10 deletions(-) diff --git a/packages/SystemUI/src/com/android/systemui/qs/tiles/dialog/InternetDialog.java b/packages/SystemUI/src/com/android/systemui/qs/tiles/dialog/InternetDialog.java index e3f085cfbe366..2a398496af77b 100644 --- a/packages/SystemUI/src/com/android/systemui/qs/tiles/dialog/InternetDialog.java +++ b/packages/SystemUI/src/com/android/systemui/qs/tiles/dialog/InternetDialog.java @@ -303,15 +303,11 @@ public class InternetDialog extends SystemUIDialog implements if (DEBUG) { Log.d(TAG, "updateDialog"); } - if (mInternetDialogController.isAirplaneModeEnabled()) { - mInternetDialogSubTitle.setVisibility(View.GONE); - mAirplaneModeLayout.setVisibility(View.VISIBLE); - } else { - mInternetDialogTitle.setText(getDialogTitleText()); - mInternetDialogSubTitle.setVisibility(View.VISIBLE); - mInternetDialogSubTitle.setText(getSubtitleText()); - mAirplaneModeLayout.setVisibility(View.GONE); - } + mInternetDialogTitle.setText(getDialogTitleText()); + mInternetDialogSubTitle.setText(getSubtitleText()); + mAirplaneModeLayout.setVisibility( + mInternetDialogController.isAirplaneModeEnabled() ? View.VISIBLE : View.GONE); + updateEthernet(); if (shouldUpdateMobileNetwork) { setMobileDataLayout(mInternetDialogController.activeNetworkIsCellular(), diff --git a/packages/SystemUI/tests/src/com/android/systemui/qs/tiles/dialog/InternetDialogTest.java b/packages/SystemUI/tests/src/com/android/systemui/qs/tiles/dialog/InternetDialogTest.java index 651bcdef99785..89537884903af 100644 --- a/packages/SystemUI/tests/src/com/android/systemui/qs/tiles/dialog/InternetDialogTest.java +++ b/packages/SystemUI/tests/src/com/android/systemui/qs/tiles/dialog/InternetDialogTest.java @@ -140,7 +140,7 @@ public class InternetDialogTest extends SysuiTestCase { mInternetDialog.updateDialog(true); - assertThat(mSubTitle.getVisibility()).isEqualTo(View.GONE); + assertThat(mSubTitle.getVisibility()).isEqualTo(View.VISIBLE); } @Test