Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge "Only notify SIM state changes when it has actually changed" into lmp-mr1-dev

Browse Source
This commit is contained in:
Jorim Jaggi
2015-01-14 15:13:05 +00:00
committed by Android (Google) Code Review
parent bd0db7b18f 01ba98b856
commit 86e1788db4
1 changed files with 23 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

29
packages/Keyguard/src/com/android/keyguard/KeyguardUpdateMonitor.java
View File

@@ -274,12 +274,16 @@ public class KeyguardUpdateMonitor implements TrustManager.TrustListener {
// Hack level over 9000: Because the subscription id is not yet valid when we see the // Hack level over 9000: Because the subscription id is not yet valid when we see the
// first update in handleSimStateChange, we need to force refresh all all SIM states // first update in handleSimStateChange, we need to force refresh all all SIM states
// so the subscription id for them is consistent. // so the subscription id for them is consistent.
ArrayList<SubscriptionInfo> changedSubscriptions = new ArrayList<>();
for (int i = 0; i < subscriptionInfos.size(); i++) { for (int i = 0; i < subscriptionInfos.size(); i++) {
SubscriptionInfo info = subscriptionInfos.get(i); SubscriptionInfo info = subscriptionInfos.get(i);
refreshSimState(info.getSubscriptionId(), info.getSimSlotIndex()); boolean changed = refreshSimState(info.getSubscriptionId(), info.getSimSlotIndex());
if (changed) {
changedSubscriptions.add(info);
}
} }
for (int i = 0; i < subscriptionInfos.size(); i++) { for (int i = 0; i < changedSubscriptions.size(); i++) {
SimData data = mSimDatas.get(mSubscriptionInfo.get(i).getSubscriptionId()); SimData data = mSimDatas.get(changedSubscriptions.get(i).getSubscriptionId());
for (int j = 0; j < mCallbacks.size(); j++) { for (int j = 0; j < mCallbacks.size(); j++) {
KeyguardUpdateMonitorCallback cb = mCallbacks.get(j).get(); KeyguardUpdateMonitorCallback cb = mCallbacks.get(j).get();
if (cb != null) { if (cb != null) {
@@ -1242,7 +1246,10 @@ public class KeyguardUpdateMonitor implements TrustManager.TrustListener {
} }
} }
private void refreshSimState(int subId, int slotId) { /**
* @return true if and only if the state has changed for the specified {@code slotId}
*/
private boolean refreshSimState(int subId, int slotId) {
// This is awful. It exists because there are two APIs for getting the SIM status // This is awful. It exists because there are two APIs for getting the SIM status
// that don't return the complete set of values and have different types. In Keyguard we // that don't return the complete set of values and have different types. In Keyguard we
@@ -1256,8 +1263,18 @@ public class KeyguardUpdateMonitor implements TrustManager.TrustListener {
} catch(IllegalArgumentException ex) { } catch(IllegalArgumentException ex) {
Log.w(TAG, "Unknown sim state: " + simState); Log.w(TAG, "Unknown sim state: " + simState);
state = State.UNKNOWN; state = State.UNKNOWN;
} }
mSimDatas.put(subId, new SimData(state, slotId, subId)); SimData data = mSimDatas.get(subId);
final boolean changed;
if (data == null) {
data = new SimData(state, slotId, subId);
mSimDatas.put(subId, data);
changed = true; // no data yet; force update
} else {
changed = data.simState != state;
data.simState = state;
}
return changed;
} }
public static boolean isSimPinSecure(IccCardConstants.State state) { public static boolean isSimPinSecure(IccCardConstants.State state) {