From 867ceacb77f75c3d50abcfcfc69d5449c3b84b56 Mon Sep 17 00:00:00 2001 From: Yohei Yukawa Date: Thu, 13 Oct 2022 21:53:02 -0700 Subject: [PATCH] Inline IMM.DelegateImpl#finishInput() This CL inlines InputMethodManager.DelegateImpl#finishInput(). There must be no observable behavior change except for we no longer log IME tracing event "InputMethodManager.DelegateImpl#finishInput". If that event is turned out to be useful, we can add a similar tag later, but for now it doesn't look to be critically useful. Bug: 234882948 Test: presubmit Change-Id: Ie204f9f665e9ab4814100068ac357fbb4b26b5a5 --- .../view/inputmethod/InputMethodManager.java | 13 ++----------- 1 file changed, 2 insertions(+), 11 deletions(-) diff --git a/core/java/android/view/inputmethod/InputMethodManager.java b/core/java/android/view/inputmethod/InputMethodManager.java index 4d9f6f5fb5c85..84e711c6a27cc 100644 --- a/core/java/android/view/inputmethod/InputMethodManager.java +++ b/core/java/android/view/inputmethod/InputMethodManager.java @@ -738,15 +738,6 @@ public final class InputMethodManager { private final class DelegateImpl implements ImeFocusController.InputMethodManagerDelegate { - private void finishInput() { - ImeTracing.getInstance().triggerClientDump( - "InputMethodManager.DelegateImpl#finishInput", InputMethodManager.this, - null /* icProto */); - synchronized (mH) { - finishInputLocked(); - } - } - /** * Used by {@link ImeFocusController} to finish input connection and callback * {@link InputMethodService#onFinishInput()}. @@ -899,7 +890,7 @@ public final class InputMethodManager { } // Close the connection when no next served view coming. if (mNextServedView == null) { - finishInput(); + finishInputLocked(); closeCurrentInput(); return false; } @@ -939,7 +930,7 @@ public final class InputMethodManager { return; } if (mServedView != null) { - finishInput(); + finishInputLocked(); } setCurrentRootView(null); }