Merge "[Bluetooth] Avoid crash from emtpy devcie name." into udc-d1-dev

This commit is contained in:
Tom Hsu
2023-06-30 05:48:44 +00:00
committed by Android (Google) Code Review
2 changed files with 8 additions and 1 deletions

View File

@@ -583,7 +583,7 @@ public class CachedBluetoothDevice implements Comparable<CachedBluetoothDevice>
*/
public void setName(String name) {
// Prevent getName() to be set to null if setName(null) is called
if (name == null || TextUtils.equals(name, getName())) {
if (TextUtils.isEmpty(name) || TextUtils.equals(name, getName())) {
return;
}
mDevice.setAlias(name);

View File

@@ -1014,6 +1014,13 @@ public class CachedBluetoothDeviceTest {
verify(mDevice, never()).setAlias(any());
}
@Test
public void setName_setDeviceNameIsEmpty() {
mCachedDevice.setName("");
verify(mDevice, never()).setAlias(any());
}
@Test
public void getProfileConnectionState_nullProfile_returnDisconnected() {
assertThat(mCachedDevice.getProfileConnectionState(null)).isEqualTo(