From 7f3e096b70bc45449c6ffc7c17b9f5f938531603 Mon Sep 17 00:00:00 2001 From: Hans Boehm Date: Tue, 19 Apr 2022 14:55:30 -0700 Subject: [PATCH] Don't MAP_POPULATE native ZygoteCommandBuffer Since we made it significantly larger, populating it will often waste a bit of space. Belated follow-up to aosp/2009575 . Test: Build and boot AOSP. Bug: 219763513 Change-Id: I5fdbd379942e92df52c079e52e35ebbee0429577 --- core/jni/com_android_internal_os_ZygoteCommandBuffer.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/core/jni/com_android_internal_os_ZygoteCommandBuffer.cpp b/core/jni/com_android_internal_os_ZygoteCommandBuffer.cpp index 679a4f070290e..add645dee7180 100644 --- a/core/jni/com_android_internal_os_ZygoteCommandBuffer.cpp +++ b/core/jni/com_android_internal_os_ZygoteCommandBuffer.cpp @@ -296,7 +296,7 @@ jlong com_android_internal_os_ZygoteCommandBuffer_getNativeBuffer(JNIEnv* env, j ++buffersAllocd; // MMap explicitly to get it page aligned. void *bufferMem = mmap(NULL, sizeof(NativeCommandBuffer), PROT_READ | PROT_WRITE, - MAP_ANONYMOUS | MAP_PRIVATE | MAP_POPULATE, -1, 0); + MAP_ANONYMOUS | MAP_PRIVATE, -1, 0); // Currently we mmap and unmap one for every request handled by the Java code. // That could be improved, but unclear it matters. if (bufferMem == MAP_FAILED) {