From 849911a9c4315fc552faa38516c842b2541b1909 Mon Sep 17 00:00:00 2001
From: John Reck <jreck@google.com>
Date: Tue, 20 Jan 2015 07:51:14 -0800
Subject: [PATCH] Move Canvas

Change-Id: I83d557af30fc2d5c69d06eedc0f4d52ac41c4210
---
 core/jni/Android.mk                           |  1 -
 core/jni/android/graphics/Canvas.h            | 19 -----------
 core/jni/android_graphics_Canvas.cpp          |  2 +-
 libs/hwui/Android.common.mk                   |  1 +
 libs/hwui/Android.mk                          |  1 -
 .../private/graphics => libs/hwui}/Canvas.h   | 10 +++---
 libs/hwui/DisplayListRenderer.h               |  3 +-
 .../graphics => libs/hwui}/SkiaCanvas.cpp     | 32 ++++++-------------
 8 files changed, 19 insertions(+), 50 deletions(-)
 delete mode 100644 core/jni/android/graphics/Canvas.h
 rename {include/private/graphics => libs/hwui}/Canvas.h (98%)
 rename {core/jni/android/graphics => libs/hwui}/SkiaCanvas.cpp (98%)

diff --git a/core/jni/Android.mk b/core/jni/Android.mk
index 398d2110d0411..cb9b4217c59c4 100644
--- a/core/jni/Android.mk
+++ b/core/jni/Android.mk
@@ -117,7 +117,6 @@ LOCAL_SRC_FILES:= \
     android/graphics/Rasterizer.cpp \
     android/graphics/Region.cpp \
     android/graphics/Shader.cpp \
-    android/graphics/SkiaCanvas.cpp \
     android/graphics/SurfaceTexture.cpp \
     android/graphics/Typeface.cpp \
     android/graphics/TypefaceImpl.cpp \
diff --git a/core/jni/android/graphics/Canvas.h b/core/jni/android/graphics/Canvas.h
deleted file mode 100644
index 2577a900ae011..0000000000000
--- a/core/jni/android/graphics/Canvas.h
+++ /dev/null
@@ -1,19 +0,0 @@
-/*
- * Copyright (C) 2014 The Android Open Source Project
- *
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- *      http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-
-// This header is shared with other libraries and as such is located in a
-// separate directory.
-#include <private/graphics/Canvas.h>
diff --git a/core/jni/android_graphics_Canvas.cpp b/core/jni/android_graphics_Canvas.cpp
index b98dbca5ffcaf..7d5ca8d246716 100644
--- a/core/jni/android_graphics_Canvas.cpp
+++ b/core/jni/android_graphics_Canvas.cpp
@@ -18,7 +18,7 @@
 #include "GraphicsJNI.h"
 #include "core_jni_helpers.h"
 
-#include "Canvas.h"
+#include <Canvas.h>
 #include "SkDrawFilter.h"
 #include "SkGraphics.h"
 #include "SkPorterDuff.h"
diff --git a/libs/hwui/Android.common.mk b/libs/hwui/Android.common.mk
index b044e02b2d64b..59a47de7ae89a 100644
--- a/libs/hwui/Android.common.mk
+++ b/libs/hwui/Android.common.mk
@@ -52,6 +52,7 @@ LOCAL_SRC_FILES := \
     RenderState.cpp \
     ResourceCache.cpp \
     ShadowTessellator.cpp \
+    SkiaCanvas.cpp \
     SkiaShader.cpp \
     Snapshot.cpp \
     SpotShadow.cpp \
diff --git a/libs/hwui/Android.mk b/libs/hwui/Android.mk
index aa8db265d8477..91e289c32b97e 100644
--- a/libs/hwui/Android.mk
+++ b/libs/hwui/Android.mk
@@ -4,7 +4,6 @@ LOCAL_ADDITIONAL_DEPENDENCIES := $(LOCAL_PATH)/Android.mk
 
 LOCAL_MODULE_CLASS := SHARED_LIBRARIES
 LOCAL_MODULE := libhwui
-LOCAL_MODULE_TAGS := optional
 
 include $(LOCAL_PATH)/Android.common.mk
 
diff --git a/include/private/graphics/Canvas.h b/libs/hwui/Canvas.h
similarity index 98%
rename from include/private/graphics/Canvas.h
rename to libs/hwui/Canvas.h
index ae79907f11339..f9c86200fdf80 100644
--- a/include/private/graphics/Canvas.h
+++ b/libs/hwui/Canvas.h
@@ -17,13 +17,15 @@
 #ifndef ANDROID_GRAPHICS_CANVAS_H
 #define ANDROID_GRAPHICS_CANVAS_H
 
-#include "SkBitmap.h"
-#include "SkCanvas.h"
-#include "SkMatrix.h"
+#include <cutils/compiler.h>
+
+#include <SkBitmap.h>
+#include <SkCanvas.h>
+#include <SkMatrix.h>
 
 namespace android {
 
-class Canvas {
+class ANDROID_API Canvas {
 public:
     virtual ~Canvas() {};
 
diff --git a/libs/hwui/DisplayListRenderer.h b/libs/hwui/DisplayListRenderer.h
index 8f8d24cceb700..631290d3dc811 100644
--- a/libs/hwui/DisplayListRenderer.h
+++ b/libs/hwui/DisplayListRenderer.h
@@ -25,8 +25,7 @@
 #include <SkTLazy.h>
 #include <cutils/compiler.h>
 
-#include <private/graphics/Canvas.h>
-
+#include "Canvas.h"
 #include "CanvasState.h"
 #include "DisplayList.h"
 #include "DisplayListLogBuffer.h"
diff --git a/core/jni/android/graphics/SkiaCanvas.cpp b/libs/hwui/SkiaCanvas.cpp
similarity index 98%
rename from core/jni/android/graphics/SkiaCanvas.cpp
rename to libs/hwui/SkiaCanvas.cpp
index 31c65143b766a..7fdbf9a7cd751 100644
--- a/core/jni/android/graphics/SkiaCanvas.cpp
+++ b/libs/hwui/SkiaCanvas.cpp
@@ -14,30 +14,18 @@
  * limitations under the License.
  */
 
-#include "jni.h"
 #include "Canvas.h"
-#include "GraphicsJNI.h"
-#include <android_runtime/AndroidRuntime.h>
 
-#include "SkCanvas.h"
-#include "SkClipStack.h"
-#include "SkDevice.h"
-#include "SkDeque.h"
-#include "SkDrawFilter.h"
-#include "SkGraphics.h"
-#include "SkPorterDuff.h"
-#include "SkShader.h"
-#include "SkTArray.h"
-#include "SkTemplates.h"
-
-#include "MinikinUtils.h"
-
-#include "TypefaceImpl.h"
-
-#include "unicode/ubidi.h"
-#include "unicode/ushape.h"
-
-#include <utils/Log.h>
+#include <SkCanvas.h>
+#include <SkClipStack.h>
+#include <SkDevice.h>
+#include <SkDeque.h>
+#include <SkDrawFilter.h>
+#include <SkGraphics.h>
+#include <SkPorterDuff.h>
+#include <SkShader.h>
+#include <SkTArray.h>
+#include <SkTemplates.h>
 
 namespace android {