Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge change 5237 into donut

Browse Source 
* changes:
  Calling setItemChecked(p, true) twice would toggle the selection in ListView.
This commit is contained in:
Android (Google) Code Review
2009-06-24 12:59:15 -07:00
parent a4335ee8a7 8842f0bd5c
commit 83f6b13018
1 changed files with 6 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
core/java/android/widget/ListView.java
View File

@@ -3264,9 +3264,13 @@ public class ListView extends AbsListView {
if (mChoiceMode == CHOICE_MODE_MULTIPLE) { if (mChoiceMode == CHOICE_MODE_MULTIPLE) {
mCheckStates.put(position, value); mCheckStates.put(position, value);
} else { } else {
boolean oldValue = mCheckStates.get(position, false); // Clear the old value: if something was selected and value == false
// then it is unselected
mCheckStates.clear(); mCheckStates.clear();
if (!oldValue) { // If value == true, select the appropriate position
// this may end up selecting the value we just cleared but this way
// we don't have to first to a get(position)
if (value) {
mCheckStates.put(position, true); mCheckStates.put(position, true);
} }
} }