Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge "Return the correct root task when start activity from recents" into sc-v2-dev

Browse Source
This commit is contained in:
TreeHugger Robot
2021-09-16 01:35:22 +00:00
committed by Android (Google) Code Review
parent bb7bd1873c bd6bb3f503
commit 83c1ab8a4b
2 changed files with 13 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
services/core/java/com/android/server/wm/TaskDisplayArea.java
View File

@@ -1095,29 +1095,27 @@ final class TaskDisplayArea extends DisplayArea<WindowContainer> {
return rootTask; return rootTask;
} }
} else if (candidateTask != null) { } else if (candidateTask != null) {
final Task rootTask = candidateTask;
final int position = onTop ? POSITION_TOP : POSITION_BOTTOM; final int position = onTop ? POSITION_TOP : POSITION_BOTTOM;
final Task launchRootTask = getLaunchRootTask(windowingMode, activityType, options, final Task launchRootTask = getLaunchRootTask(windowingMode, activityType, options,
sourceTask, launchFlags); sourceTask, launchFlags);
if (launchRootTask != null) { if (launchRootTask != null) {
if (rootTask.getParent() == null) { if (candidateTask.getParent() == null) {
launchRootTask.addChild(rootTask, position); launchRootTask.addChild(candidateTask, position);
} else if (rootTask.getParent() != launchRootTask) { } else if (candidateTask.getParent() != launchRootTask) {
rootTask.reparent(launchRootTask, position); candidateTask.reparent(launchRootTask, position);
} }
} else if (rootTask.getDisplayArea() != this || !rootTask.isRootTask()) { } else if (candidateTask.getDisplayArea() != this || !candidateTask.isRootTask()) {
if (rootTask.getParent() == null) { if (candidateTask.getParent() == null) {
addChild(rootTask, position); addChild(candidateTask, position);
} else { } else {
rootTask.reparent(this, onTop); candidateTask.reparent(this, onTop);
} }
} }
// Update windowing mode if necessary, e.g. moving a pinned task to fullscreen. // Update windowing mode if necessary, e.g. moving a pinned task to fullscreen.
if (candidateTask.getWindowingMode() != windowingMode) { if (candidateTask.getWindowingMode() != windowingMode) {
candidateTask.setWindowingMode(windowingMode); candidateTask.setWindowingMode(windowingMode);
} }
return rootTask; return candidateTask.getRootTask();
} }
return new Task.Builder(mAtmService) return new Task.Builder(mAtmService)
.setWindowingMode(windowingMode) .setWindowingMode(windowingMode)

4
services/core/java/com/android/server/wm/WindowContainer.java
View File

@@ -354,6 +354,10 @@ class WindowContainer<E extends WindowContainer> extends ConfigurationContainer<
throw new IllegalArgumentException("reparent: can't reparent to null " + this); throw new IllegalArgumentException("reparent: can't reparent to null " + this);
} }
if (newParent == this) {
throw new IllegalArgumentException("Can not reparent to itself " + this);
}
final WindowContainer oldParent = mParent; final WindowContainer oldParent = mParent;
if (mParent == newParent) { if (mParent == newParent) {
throw new IllegalArgumentException("WC=" + this + " already child of " + mParent); throw new IllegalArgumentException("WC=" + this + " already child of " + mParent);