From 521600d062085aa0ee32eeb8898fe3d8b4bfed85 Mon Sep 17 00:00:00 2001 From: sallyyuen Date: Fri, 1 Jul 2022 08:56:42 -0700 Subject: [PATCH] Remove global gesture code The global gesture to enable a11y is obsolete with the shortcut. Remove the aidl method and implementation in AccessibilityManagerService Test: builds and run CTS suite Bug: 237687851 Change-Id: I9390e6e4a82d638046fd6adcbacb7a8b5fc8cbf4 --- .../accessibility/IAccessibilityManager.aidl | 3 -- .../AccessibilityManagerService.java | 43 ------------------- 2 files changed, 46 deletions(-) diff --git a/core/java/android/view/accessibility/IAccessibilityManager.aidl b/core/java/android/view/accessibility/IAccessibilityManager.aidl index 418132a6e5978..4fc9a077299ac 100644 --- a/core/java/android/view/accessibility/IAccessibilityManager.aidl +++ b/core/java/android/view/accessibility/IAccessibilityManager.aidl @@ -63,9 +63,6 @@ interface IAccessibilityManager { void unregisterUiTestAutomationService(IAccessibilityServiceClient client); - void temporaryEnableAccessibilityStateUntilKeyguardRemoved(in ComponentName service, - boolean touchExplorationEnabled); - // Used by UiAutomation IBinder getWindowToken(int windowId, int userId); diff --git a/services/accessibility/java/com/android/server/accessibility/AccessibilityManagerService.java b/services/accessibility/java/com/android/server/accessibility/AccessibilityManagerService.java index 99c8495270348..79f590f8384aa 100644 --- a/services/accessibility/java/com/android/server/accessibility/AccessibilityManagerService.java +++ b/services/accessibility/java/com/android/server/accessibility/AccessibilityManagerService.java @@ -199,9 +199,6 @@ public class AccessibilityManagerService extends IAccessibilityManager.Stub private static final String FUNCTION_REGISTER_UI_TEST_AUTOMATION_SERVICE = "registerUiTestAutomationService"; - private static final String TEMPORARY_ENABLE_ACCESSIBILITY_UNTIL_KEYGUARD_REMOVED = - "temporaryEnableAccessibilityStateUntilKeyguardRemoved"; - private static final String GET_WINDOW_TOKEN = "getWindowToken"; private static final String SET_PIP_ACTION_REPLACEMENT = @@ -1234,46 +1231,6 @@ public class AccessibilityManagerService extends IAccessibilityManager.Stub } } - @Override - public void temporaryEnableAccessibilityStateUntilKeyguardRemoved( - ComponentName service, boolean touchExplorationEnabled) { - if (mTraceManager.isA11yTracingEnabledForTypes(FLAGS_ACCESSIBILITY_MANAGER)) { - mTraceManager.logTrace( - LOG_TAG + ".temporaryEnableAccessibilityStateUntilKeyguardRemoved", - FLAGS_ACCESSIBILITY_MANAGER, - "service=" + service + ";touchExplorationEnabled=" + touchExplorationEnabled); - } - - mSecurityPolicy.enforceCallingPermission( - Manifest.permission.TEMPORARY_ENABLE_ACCESSIBILITY, - TEMPORARY_ENABLE_ACCESSIBILITY_UNTIL_KEYGUARD_REMOVED); - if (mTraceManager.isA11yTracingEnabledForTypes(FLAGS_WINDOW_MANAGER_INTERNAL)) { - mTraceManager.logTrace("WindowManagerInternal.isKeyguardLocked", - FLAGS_WINDOW_MANAGER_INTERNAL); - } - if (!mWindowManagerService.isKeyguardLocked()) { - return; - } - synchronized (mLock) { - // Set the temporary state. - AccessibilityUserState userState = getCurrentUserStateLocked(); - - userState.setTouchExplorationEnabledLocked(touchExplorationEnabled); - userState.setDisplayMagnificationEnabledLocked(false); - userState.disableShortcutMagnificationLocked(); - userState.setAutoclickEnabledLocked(false); - userState.mEnabledServices.clear(); - userState.mEnabledServices.add(service); - userState.getBindingServicesLocked().clear(); - userState.getCrashedServicesLocked().clear(); - userState.mTouchExplorationGrantedServices.clear(); - userState.mTouchExplorationGrantedServices.add(service); - - // User the current state instead settings. - onUserStateChangedLocked(userState); - } - } - @Override public IBinder getWindowToken(int windowId, int userId) { if (mTraceManager.isA11yTracingEnabledForTypes(FLAGS_ACCESSIBILITY_MANAGER)) {