From 990db93814fc2a9a2e698a8938f0bad7f0ad8802 Mon Sep 17 00:00:00 2001 From: Nataniel Borges Date: Wed, 24 Feb 2021 12:16:41 +0100 Subject: [PATCH] Promote stable open app from overview tests Promote stable postsubmit and flaky tests to presubmit Test: atest FlickerTests:OpenAppFromOverviewTest Bug: 162923992 Change-Id: I81fff61439c90149bf6bea9b7bb5067e83e5e3bc --- .../flicker/launch/OpenAppFromOverviewTest.kt | 29 +++++++++++++++---- 1 file changed, 23 insertions(+), 6 deletions(-) diff --git a/tests/FlickerTests/src/com/android/server/wm/flicker/launch/OpenAppFromOverviewTest.kt b/tests/FlickerTests/src/com/android/server/wm/flicker/launch/OpenAppFromOverviewTest.kt index e2a258aea239e..18fac6a82de78 100644 --- a/tests/FlickerTests/src/com/android/server/wm/flicker/launch/OpenAppFromOverviewTest.kt +++ b/tests/FlickerTests/src/com/android/server/wm/flicker/launch/OpenAppFromOverviewTest.kt @@ -17,7 +17,6 @@ package com.android.server.wm.flicker.launch import android.app.Instrumentation -import android.platform.test.annotations.Postsubmit import android.platform.test.annotations.Presubmit import android.view.Surface import androidx.test.filters.FlakyTest @@ -148,17 +147,35 @@ class OpenAppFromOverviewTest(private val testSpec: FlickerTestParameter) { @Test fun focusChanges() = testSpec.focusChanges("NexusLauncherActivity", testApp.`package`) - @Postsubmit + @Presubmit @Test - fun visibleWindowsShownMoreThanOneConsecutiveEntry() = + fun visibleWindowsShownMoreThanOneConsecutiveEntry() { + Assume.assumeFalse(testSpec.isRotated) testSpec.visibleWindowsShownMoreThanOneConsecutiveEntry() + } @FlakyTest @Test - fun visibleLayersShownMoreThanOneConsecutiveEntry() = - testSpec.visibleLayersShownMoreThanOneConsecutiveEntry() + fun visibleWindowsShownMoreThanOneConsecutiveEntry_Flaky() { + Assume.assumeTrue(testSpec.isRotated) + testSpec.visibleWindowsShownMoreThanOneConsecutiveEntry() + } - @FlakyTest(bugId = 141361128) + @Presubmit + @Test + fun visibleLayersShownMoreThanOneConsecutiveEntry() { + Assume.assumeFalse(testSpec.isRotated) + testSpec.visibleLayersShownMoreThanOneConsecutiveEntry() + } + + @FlakyTest + @Test + fun visibleLayersShownMoreThanOneConsecutiveEntry_Flaky() { + Assume.assumeTrue(testSpec.isRotated) + testSpec.visibleLayersShownMoreThanOneConsecutiveEntry() + } + + @Presubmit @Test fun noUncoveredRegions() = testSpec.noUncoveredRegions(Surface.ROTATION_0, testSpec.config.endRotation)