From 70d3892c75d067d9156e32b23bd86074f268c27a Mon Sep 17 00:00:00 2001
From: Fabian Kozynski <kozynski@google.com>
Date: Fri, 9 Apr 2021 12:59:54 -0400
Subject: [PATCH] Make phone call row in Privacy Dialog not clickable

Test: manual
Test: atest PrivacyDialogTest
Fixes: 184891193
Change-Id: If2421a4d8a45309fc30c2d92f7150378dc94958d
---
 .../res/layout/privacy_dialog_item.xml        |  1 +
 .../android/systemui/privacy/PrivacyDialog.kt |  7 ++++++-
 .../systemui/privacy/PrivacyDialogTest.kt     | 21 +++++++++++++++++++
 3 files changed, 28 insertions(+), 1 deletion(-)

diff --git a/packages/SystemUI/res/layout/privacy_dialog_item.xml b/packages/SystemUI/res/layout/privacy_dialog_item.xml
index 91ffe225fac6f..0c8ed9f7ff2af 100644
--- a/packages/SystemUI/res/layout/privacy_dialog_item.xml
+++ b/packages/SystemUI/res/layout/privacy_dialog_item.xml
@@ -51,6 +51,7 @@
     />
 
     <ImageView
+        android:id="@+id/chevron"
         android:layout_height="24dp"
         android:layout_width="24dp"
         android:layout_gravity="center_vertical"
diff --git a/packages/SystemUI/src/com/android/systemui/privacy/PrivacyDialog.kt b/packages/SystemUI/src/com/android/systemui/privacy/PrivacyDialog.kt
index 8ec9b682ffdc4..dc22dc17cb859 100644
--- a/packages/SystemUI/src/com/android/systemui/privacy/PrivacyDialog.kt
+++ b/packages/SystemUI/src/com/android/systemui/privacy/PrivacyDialog.kt
@@ -128,9 +128,14 @@ class PrivacyDialog(
             )
         } ?: firstLine
         newView.requireViewById<TextView>(R.id.text).text = finalText
+        if (element.phoneCall) {
+            newView.requireViewById<View>(R.id.chevron).visibility = View.GONE
+        }
         newView.apply {
             setTag(element)
-            setOnClickListener(clickListener)
+            if (!element.phoneCall) {
+                setOnClickListener(clickListener)
+            }
         }
         return newView
     }
diff --git a/packages/SystemUI/tests/src/com/android/systemui/privacy/PrivacyDialogTest.kt b/packages/SystemUI/tests/src/com/android/systemui/privacy/PrivacyDialogTest.kt
index 28b44d94effb8..1baaf6b827f15 100644
--- a/packages/SystemUI/tests/src/com/android/systemui/privacy/PrivacyDialogTest.kt
+++ b/packages/SystemUI/tests/src/com/android/systemui/privacy/PrivacyDialogTest.kt
@@ -233,6 +233,27 @@ class PrivacyDialogTest : SysuiTestCase() {
         )
     }
 
+    @Test
+    fun testPhoneCallNotClickable() {
+        val element = PrivacyDialog.PrivacyElement(
+                PrivacyType.TYPE_MICROPHONE,
+                TEST_PACKAGE_NAME,
+                TEST_USER_ID,
+                "App",
+                null,
+                0L,
+                false,
+                false,
+                true
+        )
+
+        val list = listOf(element)
+        dialog = PrivacyDialog(context, list, starter)
+        dialog.show()
+        assertThat(dialog.requireViewById<View>(R.id.privacy_item).isClickable).isFalse()
+        assertThat(dialog.requireViewById<View>(R.id.chevron).visibility).isEqualTo(View.GONE)
+    }
+
     @Test
     fun testAttribution() {
         val element = PrivacyDialog.PrivacyElement(