From 81c262b6d90566e68d3fc5973ccf57d6c72ac4fc Mon Sep 17 00:00:00 2001
From: Charles Munger <clm@google.com>
Date: Mon, 18 Nov 2019 10:51:17 -0800
Subject: [PATCH] Deprecate TimingLogger

Bug: 144042891
Test: No behavior changes
Change-Id: I78af3549a2bf56eb709c52483c97acc5ddb15e87
---
 api/current.txt                          | 12 ++++++------
 core/java/android/util/TimingLogger.java |  7 +++++++
 2 files changed, 13 insertions(+), 6 deletions(-)

diff --git a/api/current.txt b/api/current.txt
index 1a87b2257d279..6a2d322451803 100644
--- a/api/current.txt
+++ b/api/current.txt
@@ -48521,12 +48521,12 @@ package android.util {
     method @Nullable public static java.util.List<java.lang.String> getTimeZoneIdsForCountryCode(@NonNull String);
   }
 
-  public class TimingLogger {
-    ctor public TimingLogger(String, String);
-    method public void addSplit(String);
-    method public void dumpToLog();
-    method public void reset(String, String);
-    method public void reset();
+  @Deprecated public class TimingLogger {
+    ctor @Deprecated public TimingLogger(String, String);
+    method @Deprecated public void addSplit(String);
+    method @Deprecated public void dumpToLog();
+    method @Deprecated public void reset(String, String);
+    method @Deprecated public void reset();
   }
 
   public class TypedValue {
diff --git a/core/java/android/util/TimingLogger.java b/core/java/android/util/TimingLogger.java
index be442dac630af..5a4a512c283b2 100644
--- a/core/java/android/util/TimingLogger.java
+++ b/core/java/android/util/TimingLogger.java
@@ -44,7 +44,14 @@ import android.os.SystemClock;
  *     D/TAG     ( 3459): methodA:      6 ms, work C
  *     D/TAG     ( 3459): methodA: end, 16 ms
  * </pre>
+ *
+ * @deprecated Use {@link android.os.Trace}, or
+ *   <a href="https://developer.android.com/studio/profile/benchmark">Android Studio</a>. In
+ *   general, milliseconds is the wrong granularity for method-level tracing. Rounding errors
+ *   can overemphasize cheap operations, or underemphasize repeated operations. This timing
+ *   system also does not take CPU scheduling or frequency into account.
  */
+@Deprecated
 public class TimingLogger {
 
     /**