Android/frameworks_base
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge "Don't cap the targetSDK for change id's in UI"

Browse Source
This commit is contained in:
Andrei-Valentin Onea
2020-12-23 13:08:18 +00:00
committed by Gerrit Code Review
parent 8553f77dce 156147cafc
commit 816f4ed50f
2 changed files with 9 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
services/core/java/com/android/server/compat/PlatformCompat.java
View File

@@ -60,7 +60,6 @@ public class PlatformCompat extends IPlatformCompat.Stub {
private final CompatConfig mCompatConfig; private final CompatConfig mCompatConfig;
private static int sMinTargetSdk = Build.VERSION_CODES.Q; private static int sMinTargetSdk = Build.VERSION_CODES.Q;
private static int sMaxTargetSdk = Build.VERSION_CODES.R;
public PlatformCompat(Context context) { public PlatformCompat(Context context) {
mContext = context; mContext = context;
@@ -384,8 +383,7 @@ public class PlatformCompat extends IPlatformCompat.Stub {
return false; return false;
} }
if (change.getEnableSinceTargetSdk() > 0) { if (change.getEnableSinceTargetSdk() > 0) {
if (change.getEnableSinceTargetSdk() < sMinTargetSdk if (change.getEnableSinceTargetSdk() < sMinTargetSdk) {
|| change.getEnableSinceTargetSdk() > sMaxTargetSdk) {
return false; return false;
} }
} }

14
services/tests/servicestests/src/com/android/server/compat/PlatformCompatTest.java
View File

@@ -107,18 +107,20 @@ public class PlatformCompatTest {
mCompatConfig = CompatConfigBuilder.create(mBuildClassifier, mContext) mCompatConfig = CompatConfigBuilder.create(mBuildClassifier, mContext)
.addEnabledChangeWithId(1L) .addEnabledChangeWithId(1L)
.addDisabledChangeWithIdAndName(2L, "change2") .addDisabledChangeWithIdAndName(2L, "change2")
.addEnableAfterSdkChangeWithIdAndDescription(Build.VERSION_CODES.O, 3L, "desc") .addEnableSinceSdkChangeWithIdAndDescription(Build.VERSION_CODES.O, 3L, "desc")
.addEnableAfterSdkChangeWithId(Build.VERSION_CODES.P, 4L) .addEnableSinceSdkChangeWithId(Build.VERSION_CODES.P, 4L)
.addEnableAfterSdkChangeWithId(Build.VERSION_CODES.Q, 5L) .addEnableSinceSdkChangeWithId(Build.VERSION_CODES.Q, 5L)
.addEnableAfterSdkChangeWithId(Build.VERSION_CODES.R, 6L) .addEnableSinceSdkChangeWithId(Build.VERSION_CODES.R, 6L)
.addLoggingOnlyChangeWithId(7L) .addLoggingOnlyChangeWithId(7L)
.build(); .build();
mPlatformCompat = new PlatformCompat(mContext, mCompatConfig); mPlatformCompat = new PlatformCompat(mContext, mCompatConfig);
assertThat(mPlatformCompat.listUIChanges()).asList().containsExactly( assertThat(mPlatformCompat.listUIChanges()).asList().containsExactly(
new CompatibilityChangeInfo(1L, "", -1, -1, false, false, ""), new CompatibilityChangeInfo(1L, "", -1, -1, false, false, ""),
new CompatibilityChangeInfo(2L, "change2", -1, -1, true, false, ""), new CompatibilityChangeInfo(2L, "change2", -1, -1, true, false, ""),
new CompatibilityChangeInfo(4L, "", Build.VERSION_CODES.P, -1, false, false, ""), new CompatibilityChangeInfo(5L, "", /*enableAfter*/ -1,
new CompatibilityChangeInfo(5L, "", Build.VERSION_CODES.Q, -1, false, false, "")); /*enableSince*/ Build.VERSION_CODES.Q, false, false, ""),
new CompatibilityChangeInfo(6L, "", /*enableAfter*/ -1,
/*enableSince*/ Build.VERSION_CODES.R, false, false, ""));
} }
@Test @Test