From 8092cdaeda1c81af3f00bbc2931d5bbd11c9d937 Mon Sep 17 00:00:00 2001 From: Felipe Leme Date: Tue, 14 May 2019 10:14:02 -0700 Subject: [PATCH] Fixed NPE on VoiceInteractor.destroy() Fixes: 131411751 Test: atest CtsVoiceInteractionTestCases # ran a few times on different devices, got no failures Change-Id: I484db53772bf503f091f30f67ae92c8ae52d4105 --- core/java/android/app/VoiceInteractor.java | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/core/java/android/app/VoiceInteractor.java b/core/java/android/app/VoiceInteractor.java index 7828573885a36..b37120faf2813 100644 --- a/core/java/android/app/VoiceInteractor.java +++ b/core/java/android/app/VoiceInteractor.java @@ -79,10 +79,10 @@ public final class VoiceInteractor { /** @hide */ public static final String KEY_KILL_SIGNAL = "key_kill_signal"; - IVoiceInteractor mInteractor; + @Nullable IVoiceInteractor mInteractor; - Context mContext; - Activity mActivity; + @Nullable Context mContext; + @Nullable Activity mActivity; boolean mRetaining; final HandlerCaller mHandlerCaller; @@ -999,7 +999,9 @@ public final class VoiceInteractor { // destroyed now mInteractor = null; - mActivity.setVoiceInteractor(null); + if (mActivity != null) { + mActivity.setVoiceInteractor(null); + } } public boolean submitRequest(Request request) {