From 20f5049835f4e8e311c85ec0b161c84484a2a007 Mon Sep 17 00:00:00 2001 From: Lucas Dupin Date: Fri, 13 Mar 2020 04:42:19 +0000 Subject: [PATCH] Revert "Fix bouncer race condition" This reverts commit 8833d1eb4c75ab8b6ed7712b2ab7ce48307d3f4e. Reason for revert: b/151050221 Fixes: 151050221 Change-Id: I5ad75dae0471a4e87b46e5fc2f95f38bb010c4c0 --- .../keyguard/KeyguardSecurityContainer.java | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/packages/SystemUI/src/com/android/keyguard/KeyguardSecurityContainer.java b/packages/SystemUI/src/com/android/keyguard/KeyguardSecurityContainer.java index 3cf07d14cbf24..ba8a1a945a777 100644 --- a/packages/SystemUI/src/com/android/keyguard/KeyguardSecurityContainer.java +++ b/packages/SystemUI/src/com/android/keyguard/KeyguardSecurityContainer.java @@ -19,9 +19,7 @@ import static android.view.ViewRootImpl.NEW_INSETS_MODE_FULL; import static android.view.ViewRootImpl.sNewInsetsMode; import static android.view.WindowInsets.Type.ime; import static android.view.WindowInsets.Type.systemBars; - import static com.android.systemui.DejankUtils.whitelistIpcs; - import static java.lang.Integer.max; import android.app.Activity; @@ -30,6 +28,7 @@ import android.app.admin.DevicePolicyManager; import android.content.Context; import android.content.Intent; import android.content.res.ColorStateList; +import android.graphics.Rect; import android.metrics.LogMaker; import android.os.Handler; import android.os.Looper; @@ -512,8 +511,6 @@ public class KeyguardSecurityContainer extends FrameLayout implements KeyguardSe boolean finish = false; boolean strongAuth = false; int eventSubtype = -1; - mCurrentSecuritySelection = whitelistIpcs(() -> - mSecurityModel.getSecurityMode(targetUserId)); if (mUpdateMonitor.getUserHasTrust(targetUserId)) { finish = true; eventSubtype = BOUNCER_DISMISS_EXTENDED_ACCESS; @@ -521,8 +518,13 @@ public class KeyguardSecurityContainer extends FrameLayout implements KeyguardSe finish = true; eventSubtype = BOUNCER_DISMISS_BIOMETRIC; } else if (SecurityMode.None == mCurrentSecuritySelection) { - finish = true; // no security required - eventSubtype = BOUNCER_DISMISS_NONE_SECURITY; + SecurityMode securityMode = mSecurityModel.getSecurityMode(targetUserId); + if (SecurityMode.None == securityMode) { + finish = true; // no security required + eventSubtype = BOUNCER_DISMISS_NONE_SECURITY; + } else { + showSecurityScreen(securityMode); // switch to the alternate security view + } } else if (authenticated) { switch (mCurrentSecuritySelection) { case Pattern: