Merge "Remove appops debug logic" into qt-dev

am: 62c6f21dac

Change-Id: Idff69ca52f522ee0e34623dd7e844c6c19f39f6e
This commit is contained in:
Chad Brubaker
2019-04-13 01:44:35 -07:00
committed by android-build-merger

View File

@@ -38,7 +38,6 @@ import android.os.Parcelable;
import android.os.Process; import android.os.Process;
import android.os.RemoteCallback; import android.os.RemoteCallback;
import android.os.RemoteException; import android.os.RemoteException;
import android.os.SystemProperties;
import android.os.UserManager; import android.os.UserManager;
import android.util.ArrayMap; import android.util.ArrayMap;
import android.util.LongSparseArray; import android.util.LongSparseArray;
@@ -5209,7 +5208,6 @@ public class AppOpsManager {
* @hide * @hide
*/ */
public int noteProxyOpNoThrow(int op, String proxiedPackageName, int proxiedUid) { public int noteProxyOpNoThrow(int op, String proxiedPackageName, int proxiedUid) {
logOperationIfNeeded(op, mContext.getOpPackageName(), proxiedPackageName);
try { try {
return mService.noteProxyOperation(op, Process.myUid(), mContext.getOpPackageName(), return mService.noteProxyOperation(op, Process.myUid(), mContext.getOpPackageName(),
proxiedUid, proxiedPackageName); proxiedUid, proxiedPackageName);
@@ -5238,7 +5236,6 @@ public class AppOpsManager {
*/ */
@UnsupportedAppUsage @UnsupportedAppUsage
public int noteOpNoThrow(int op, int uid, String packageName) { public int noteOpNoThrow(int op, int uid, String packageName) {
logOperationIfNeeded(op, packageName, null);
try { try {
return mService.noteOperation(op, uid, packageName); return mService.noteOperation(op, uid, packageName);
} catch (RemoteException e) { } catch (RemoteException e) {
@@ -5346,7 +5343,6 @@ public class AppOpsManager {
* @hide * @hide
*/ */
public int startOpNoThrow(int op, int uid, String packageName, boolean startIfModeDefault) { public int startOpNoThrow(int op, int uid, String packageName, boolean startIfModeDefault) {
logOperationIfNeeded(op, packageName, null);
try { try {
return mService.startOperation(getToken(mService), op, uid, packageName, return mService.startOperation(getToken(mService), op, uid, packageName,
startIfModeDefault); startIfModeDefault);
@@ -5363,7 +5359,6 @@ public class AppOpsManager {
* @hide * @hide
*/ */
public void finishOp(int op, int uid, String packageName) { public void finishOp(int op, int uid, String packageName) {
logOperationIfNeeded(op, packageName, null);
try { try {
mService.finishOperation(getToken(mService), op, uid, packageName); mService.finishOperation(getToken(mService), op, uid, packageName);
} catch (RemoteException e) { } catch (RemoteException e) {
@@ -5703,45 +5698,4 @@ public class AppOpsManager {
return AppOpsManager.MODE_DEFAULT; return AppOpsManager.MODE_DEFAULT;
} }
private static void logOperationIfNeeded(int op, String callingPackage, String proxiedPackage) {
// Check if debug logging propety is enabled.
if (!SystemProperties.getBoolean(DEBUG_LOGGING_ENABLE_PROP, false)) {
return;
}
// Check if this package should be logged.
String packages = SystemProperties.get(DEBUG_LOGGING_PACKAGES_PROP, "");
if (!"".equals(packages) && callingPackage != null) {
boolean found = false;
for (String pkg : packages.split(",")) {
if (callingPackage.equals(pkg)) {
found = true;
break;
}
}
if (!found) {
return;
}
}
String opStr = opToName(op);
// Check if this app op should be logged
String logOps = SystemProperties.get(DEBUG_LOGGING_OPS_PROP, "");
if (!"".equals(logOps)) {
boolean found = false;
for (String logOp : logOps.split(",")) {
if (opStr.equals(logOp)) {
found = true;
break;
}
}
if (!found) {
return;
}
}
// Log a stack trace
Exception here = new Exception("HERE!");
android.util.Log.i(DEBUG_LOGGING_TAG, "Note operation package= " + callingPackage
+ " proxied= " + proxiedPackage + " op= " + opStr, here);
}
} }