From 7fe4fe68fad547bab4bbd8133d14aeed427f5b96 Mon Sep 17 00:00:00 2001 From: Kenny Root Date: Thu, 18 Feb 2010 09:25:49 -0800 Subject: [PATCH] Range check in MediaScanner::processDirectory Make sure we don't have an empty string before checking if it's a directory since this string is tainted. Change-Id: I5eb310ced58c3c64a7af2d11b80326efe5adbcab --- media/libmedia/MediaScanner.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/media/libmedia/MediaScanner.cpp b/media/libmedia/MediaScanner.cpp index f2016671a2254..43762e7a295b2 100644 --- a/media/libmedia/MediaScanner.cpp +++ b/media/libmedia/MediaScanner.cpp @@ -58,7 +58,7 @@ status_t MediaScanner::processDirectory( int pathRemaining = PATH_MAX - pathLength; strcpy(pathBuffer, path); - if (pathBuffer[pathLength - 1] != '/') { + if (pathLength > 0 && pathBuffer[pathLength - 1]) { pathBuffer[pathLength] = '/'; pathBuffer[pathLength + 1] = 0; --pathRemaining;